1797936 - Add preconnect to existing early hint telemetry

Status: RESOLVED FIXED

(Core :: Networking: HTTP, task, P2)

Description

[Marc Leclair [:mleclair]]

We currently only support preload in the telemetry with the different type received. We should also collect the preconnect early hint to see the real total early hints that we encounter in the wild

Comment 1

[Marc Leclair [:mleclair]]

Attachment: Bug 1797936: Added preconnect telemetry to existing early hint telemetry r=valentin

Comment 2

[Marc Leclair [:mleclair]]

Attachment: Data_Request_1797936

Comment 3

[Manuel Bucher [:manuel]]

Could you expand this to also add telemetry for rel=modulepreload or should I open a separate bug for that? I just noticed that this is the way javascript module preloads are specified[1]. I've opened Bug 1798319 to track adding support for that. Our current implementation doesn't use the preloaded module script, but fetches the script twice. Somehow the test is missing. We only have a preload javascript test, not a preload module test, I probably forgot to add it.

Comment 4

[Marc Leclair [:mleclair]]

I think we can just add it here. If its for rel and the same probe. Good catch and thanks for pointing it out

Comment 5

[Chris H-C :chutten]

Comment on attachment 9300792 [details]
Data_Request_1797936

PRELIMINARY NOTES:
Since this collection is Glean, you can use ./mach data-review <bug number> to create a data review response template including all metrics that have <bug number> in their bugs fields. Should help save you some time next time.

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 109.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 6

[Manuel Bucher [:manuel]]

Attachment: Bug 1797936 - Add link type telemetry for early hint code r=#necko

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7bd771f66c1e
Add link type telemetry for early hint code r=necko-reviewers,kershaw

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7bd771f66c1e