Closed Bug 1797974 Opened 2 years ago Closed 1 year ago

Remove unused isWinVistaOrHigher from DownloadsCommon

Categories

(Toolkit :: Downloads API, task, P5)

task

Tracking

()

RESOLVED FIXED
112 Branch
Tracking Status
firefox112 --- fixed

People

(Reporter: mak, Assigned: gzyfqh, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [good-first-bug][lang=js])

Attachments

(1 file)

the isWinVistaOrHigher helper in DownloadsCommon is not used anywhere and should be removed https://searchfox.org/mozilla-central/rev/968bd894205cf4f579d94ac4e175cc3187458605/browser/components/downloads/DownloadsCommon.jsm#775

Hello @mak, I want to take over and deal with this bug, what should I pay attention to, is it enough to just remove the "isWinVistaOrHigher" parameter?

this is pure code removal, sorry for missing the question.

(In reply to Marco Bonardo [:mak] from comment #2)

this is pure code removal, sorry for missing the question.

Can't seem to find the DownloadsCommon.jsm file now, it has been removed in the new version?

it was likely renamed to .sys.mjs
You can search on searchfor.org for isWinVistaOrHigher

isWinVistaOrHigher in DownloadsCommon is no longer used, and the
relevant code will be deleted through this commit.

Assignee: nobody → gzyfqh
Status: NEW → ASSIGNED
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/3eb07a1d79b0
Remove unused isWinVistaOrHigher from DownloadsCommon. r=mak
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: