1798076 - [wpt-sync] Sync PR 36722 - Implement the suppressLocalAudioPlayback constraint

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 36722 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36722
Details from upstream follow.

Elad Alon <[e-mail]> wrote:

Implement the suppressLocalAudioPlayback constraint

The suppressLocalAudioPlayback constraint is defined in:
https://w3c.github.io/mediacapture-screen-share/#dfn-suppresslocalaudioplayback

It was added in:
https://github.com/w3c/mediacapture-screen-share/pull/164/files

Intent-to-ship with 3 LGTMs:
https://groups.google.com/a/chromium.org/g/blink-dev/c/Fm1nz7Hs7Xo

This CL implements the functionality when calling getDisplayMedia()
with the constraint already provided. The ability to toggle this
value by calling applyConstraints() will be implemented as a follow-up.

The functiionality introduced by this CL is gated behind multiple
feature flags (one for the constraint itself, a few for per-type
for refined remote-control if a surface-specific regression
is discovered.)

Bug: 1378667
Change-Id: Ia52e7b89398c4256b815c53f5640c49d32136508
Reviewed-on: https://chromium-review.googlesource.com/3982202
WPT-Export-Revision: 1810704da2639310475d720bcfd8d329636713c6

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=27f8bb2d65eaa8283c3c89d8bee72cf7b157efa6

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 58 subtests

Status Summary

Firefox

OK : 1
PASS : 50
CRASH: 1
FAIL : 8

Chrome

OK : 1
PASS : 54
FAIL : 4

Safari

OK : 1
PASS : 42
FAIL : 16

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Crashes

• /screen-capture/getdisplaymedia.https.html [wpt.fyi]: CRASH [Gecko-windows10-32-2004-qr-debug, Gecko-windows10-64-2004-qr-debug], OK [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] linked bug:Bug 1788563

Firefox-only Failures

• /screen-capture/getdisplaymedia.https.html [wpt.fyi]
  • displaySurface is supported: FAIL

New Tests That Don't Pass

• /screen-capture/getdisplaymedia.https.html [wpt.fyi]: CRASH [Gecko-windows10-32-2004-qr-debug, Gecko-windows10-64-2004-qr-debug], OK [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: OK, Safari: OK)
  • getDisplayMedia({"video":{"displaySurface":"monitor"}}) with getSettings: FAIL (Chrome: PASS, Safari: FAIL)
  • getDisplayMedia({"video":{"displaySurface":"window"}}) with getSettings: FAIL (Chrome: PASS, Safari: FAIL)
  • getDisplayMedia({"video":{"displaySurface":"browser"}}) with getSettings: FAIL (Chrome: PASS, Safari: FAIL)
  • displaySurface is supported: FAIL (Chrome: PASS, Safari: PASS)
  • getDisplayMedia({"selfBrowserSurface":"invalid"}) must fail with TypeError: FAIL (Chrome: PASS, Safari: FAIL)
  • getDisplayMedia({"surfaceSwitching":"invalid"}) must fail with TypeError: FAIL (Chrome: PASS, Safari: FAIL)
  • getDisplayMedia({"systemAudio":"invalid"}) must fail with TypeError: FAIL (Chrome: PASS, Safari: FAIL)
  • suppressLocalAudioPlayback is supported: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

• /screen-capture/getdisplaymedia.https.html [wpt.fyi]: CRASH [Gecko-windows10-32-2004-qr-debug, Gecko-windows10-64-2004-qr-debug], OK [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: OK, Safari: OK) linked bug:Bug 1788563

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/53b6c01f9df9
[wpt PR 36722] - Implement the suppressLocalAudioPlayback constraint, a=testonly
https://hg.mozilla.org/integration/autoland/rev/78ecb14b88d8
[wpt PR 36722] - Update wpt metadata, a=testonly

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/53b6c01f9df9
https://hg.mozilla.org/mozilla-central/rev/78ecb14b88d8