1798298 - Verify if we actually shutdown the CanvasRenderThread

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jens Stutte [:jstutte]]

From this crash it seems we have three (!) "CanvasRenderer" threads during a hang.

And looking at

void CanvasRenderThread::ShutDown() {
  layers::SynchronousTask task("CanvasRenderThread");
  RefPtr<Runnable> runnable =
      WrapRunnable(RefPtr<CanvasRenderThread>(sCanvasRenderThread.get()),
                   &CanvasRenderThread::ShutDownTask, &task);
  sCanvasRenderThread->PostRunnable(runnable.forget());
  task.Wait();
  sCanvasRenderThread = nullptr;
}

void CanvasRenderThread::ShutDownTask(layers::SynchronousTask* aTask) {
  layers::AutoCompleteTask complete(aTask);
  MOZ_ASSERT(IsInCanvasRenderThread());
}

I can actually not see anything here that tells the thread to shutdown. We seem to just dispatch ShutDownTask to the thread which acknowledges it immediately without taking any further action. I might overlook something, but we should probably verify this?

I'd probably propose to use the normal nsThread::Shutdown function here instead.

Comment 1

[Jens Stutte [:jstutte]]

Attachment: Bug 1798298 - Use nsThread::Shutdown to shut down the CanvasRenderThread. r?#gfx-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fcdc68693985
Use nsThread::Shutdown to shut down the CanvasRenderThread. r=gfx-reviewers,sotaro

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/fcdc68693985