Closed Bug 1798306 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 36737 - Only treat actual scrollable containers as monolithic.

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36737 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36737
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

Only treat actual scrollable containers as monolithic.

Table rows and sections, for instance, never establish scrollable
containers, even if overflow is 'scroll'. Check what we actually ended
up with, rather than checking computed style. The table layout code gets
upset by monolithic sections, and it doesn't really have to handle that
situation, as long as HasUnsplittableScrollingOverflow() behaves.

Also return early for LayoutNG here. The rest is just legacy logic that
could only do harm FragmentationEngine was NG (if it had any effect at
all; hopefully not).

Both the new tests would fail without this fix. Both would render
incorrectly. Additionally, the table sections version would also fail a
DCHECK.

Bug: 1365306
Change-Id: Ic84de292cf91141188d65a41e405bca81a2ae80f
Reviewed-on: https://chromium-review.googlesource.com/3992907
WPT-Export-Revision: e6632a179efe5bdd1d26ee76ec7910c197aafcb7

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

FAIL: 2

Chrome

FAIL: 2

Safari

PASS: 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/81904b39b1e4 [wpt PR 36737] - Only treat actual scrollable containers as monolithic., a=testonly https://hg.mozilla.org/integration/autoland/rev/bc51b48d3043 [wpt PR 36737] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/81904b39b1e4
https://hg.mozilla.org/mozilla-central/rev/bc51b48d3043

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.