Closed
Bug 1798365
Opened 2 years ago
Closed 2 years ago
Fold MMegamorphicLoadSlotByValue to MMegamorphicLoadSlot where possible
Categories
(Core :: JavaScript Engine: JIT, enhancement, P1)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
108 Branch
Tracking | Status | |
---|---|---|
firefox108 | --- | fixed |
People
(Reporter: alexical, Assigned: alexical)
References
(Blocks 1 open bug)
Details
(Whiteboard: [sp3])
Attachments
(1 file)
GetNativeDataPropertyByValuePure
was showing up in isConcatSpreadable
in matrix-react-bench. It was looking up a constant symbol on the object - in this case, we can fold it the offending MMegamorphicLoadSlotByValue
into MMegamorphicLoadSlot
, which will let us inline it and turn the id and the id hash into immediates. It's a small win.
Assignee | ||
Comment 1•2 years ago
|
||
This was showing up in the constant symbol lookup in isConcatSpreadable in
matrix-react-bench.
Updated•2 years ago
|
Assignee: nobody → dothayer
Status: NEW → ASSIGNED
Updated•2 years ago
|
Severity: -- → N/A
Priority: -- → P1
Pushed by dothayer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7de0c40b31a4
Fold MMegamorphicLoadSlotByValue where possible r=jandem
Comment 3•2 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox108:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
Updated•2 years ago
|
Whiteboard: [sp3]
Updated•2 years ago
|
See Also: → https://mozilla-hub.atlassian.net/browse/SP3-192
You need to log in
before you can comment on or make changes to this bug.
Description
•