1798617 - GeckoAppShell.isTablet always returns false

Status: RESOLVED FIXED

(GeckoView :: General, defect, P3)

Description

[Makoto Kato [:m_kato]]

When running GeckoView, HardwareUtils.init isn't called unfortunately since GeckoLoader.getLoadDiagnostics is dead code. So we should clean up HardwareUtils then isTablet returns correct value.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1798617 - GeckoAppShell.isTablet returns correct value. r=#geckoview-reviewers

Since GeckoLoader.getLoadDiagnostics is never called, HardwareUtils isn't
initialized. It means that GeckoAppShell.isTablet always return false.

So HardwareUtils should be initialized.

Also, a lot of codes in HardwareUtils and GeckoLoader.getLoadDiagnostics
are unused, so let's clean up.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1529082

Comment 3

[Pascal Chevrel:pascalc]

S4 and we are in RC week, wontfix 106.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98e6995b698a
GeckoAppShell.isTablet returns correct value. r=geckoview-reviewers,owlish

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1529082

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/98e6995b698a

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:m_kato, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox108 to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Makoto Kato [:m_kato]]

This fix is risky for beta.