1798734 - Remove osfile.jsm from browser/components/migration/SafariProfileMigrator.sys.mjs

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, task)

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Hey Angel, this one is going to be a little trickier because you're going to need to do it without having access to the platform that lets you actually use Safari. So I think we'll have you write the patch, and post it for review, but testing is something you might have to leave to myself or others with access to macOS.

There's two usages of the OSFile module here: https://searchfox.org/mozilla-central/rev/d7d2cc647772de15c4c5aa47f74d25d0e379e404/browser/components/migration/SafariProfileMigrator.sys.mjs#401-402

One is the OS.File call, and the other is OS.Path call.

The equivalents are:

• IOUtils.stat (example: https://searchfox.org/mozilla-central/rev/d7d2cc647772de15c4c5aa47f74d25d0e379e404/devtools/client/performance-new/symbolication-worker.js#141)
• PathUtils.join: https://searchfox.org/mozilla-central/rev/d7d2cc647772de15c4c5aa47f74d25d0e379e404/browser/components/migration/ChromeMigrationUtils.sys.mjs#233-236

Neither require any importing, so we can hopefully just remove the OSFile.jsm module import at the end here.

Comment 2

[Beth Rennie [:beth] (she/her)]

Here is a link to the IOUtils Migration Guide

Comment 3

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1798734 - Port osfile.jsm usage to IOUtils in SafariProfileMigrator.sys.mjs r?gijs

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:barret, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 5

[:Gijs (he/him)]

Leaving needinfo for Barret.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/925b38ccb85c
Port osfile.jsm usage to IOUtils in SafariProfileMigrator.sys.mjs r=Gijs

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/925b38ccb85c