1798805 - Regression: Send Tab via push no longer works

Status: VERIFIED FIXED

(Fenix :: Push, defect)

Description

[Jonathan Almeida [:jonalmeida]]

Starting with 106, when 991993 landed this caused the regression where push subscription is not given to the account manager correctly.

STR:

1. Sign into Sync on Fenix 106.
2. Send a tab from desktop.

Expected:

• The tab is received near instant.

Actual:

• You have to poll (press the Sync Now button) for the tab to be received.

Comment 1

[Jonathan Almeida [:jonalmeida]]

Attachment: Screen Shot 2022-10-26 at 1.01.52 PM.png

Attached is a graph from the dashboard that the app services team provided to us with the send tab error rates increasing in 106.

The fix has landed in nightly 108 and will be in the next beta 107 (if any), otherwise will make it's way into release so that we limit the regression to only one version.

Dashboard query: https://sql.telemetry.mozilla.org/queries/73067#183006

Comment 2

[Jonathan Almeida [:jonalmeida]]

Nightly 108: https://github.com/mozilla-mobile/fenix/commit/81f513e357d41d3231ee2d1c29a487b426a1a07c
Beta 107: https://github.com/mozilla-mobile/fenix/commit/2be1f86181be6c4e2f3005b5add771d4086f0caa

Leaving open until we can verify this change in our dashboards.

Comment 3

[Adina Petridean]

Verified as fixed on Firefox RC 107.1.0 build2 and Nightly 108.0a1 from 11/11 with Xiaomi Pad5 (Android 12). The tab is received via push notification right away.

Comment 4

[Adina Petridean]

@Jonathan Almeida should I leave the ticket open or can I close it since it is fixed?

Comment 5

[Jonathan Almeida [:jonalmeida]]

Let's close it then, thank you for testing! :)

Comment 6

[Jonathan Almeida [:jonalmeida]]

Attachment: Screen Shot 2022-11-21 at 12.24.46 PM.png

Error rates have started to fall with the release of 107.