1798839 - [CTW] HTML radios report incorrect group position

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[James Teh [:Jamie]]

For HTML radios, we need to use the name attribute to determine group position. Local HTMLRadioButtonAccessible has specific code to handle this. For the cache, we use the normal group position code, which doesn't know how to handle HTML radios.

We can use MEMBER_OF (as implemented in bug 1787284) to facilitate this.

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1798839 part 1: Make browser_obj_group.js work on Windows, as well as running iframe, remote iframe and chrome variants.

Comment 2

[James Teh [:Jamie]]

Attachment: Bug 1798839 part 2: Fix HTML radio group position calculation for cached RemoteAccessible.

For HTML radios, we need to group using the name attribute.
AccGroupInfo doesn't know how to do this, but that's what we were using previously for cached RemoteAccessible.
MEMBER_OF knows how to do this, so we now use that.
In future, we should probably cache this somehow, but we're not doing this for LocalAccessible, so it's not a regression at least.

The tests for this previously worked with the cache enabled, but only due to a happy accident.
The radios were grouped in such a way that the AccGroupInfo code gave the expected result.
The tests have now been updated to exercise the new code (and they fail without the C++ part of this patch if the cache is enabled).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70b7637ba679
part 1: Make browser_obj_group.js work on Windows, as well as running iframe, remote iframe and chrome variants. r=eeejay
https://hg.mozilla.org/integration/autoland/rev/ea167174ee2f
part 2: Fix HTML radio group position calculation for cached RemoteAccessible. r=eeejay

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/70b7637ba679
https://hg.mozilla.org/mozilla-central/rev/ea167174ee2f