Closed Bug 1798932 Opened 2 years ago Closed 2 years ago

Assigning to fillStyle is slow on Proxx-Tables-Canvas benchmark

Categories

(Core :: CSS Parsing and Computation, defect)

defect

Tracking

()

RESOLVED FIXED
108 Branch
Tracking Status
firefox108 --- fixed

People

(Reporter: mstange, Assigned: emilio)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [sp3-proxx-tables-canvas])

Attachments

(1 file)

Profile: https://share.firefox.dev/3UhYed4

On this benchmark we spend a considerable time parsing colors.

https://grandprixbench.netlify.app/?suites=Proxx-Tables-Canvas

Looks like the slowdown is because of the allocations made by the parser to store the text being parsed in lower case for printing it out later during serialization.

https://searchfox.org/mozilla-central/rev/eddb810ffd5499f0984123fe4bfea6064ebad3c8/servo/components/style/values/specified/color.rs#452

Severity: -- → S3
Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a0336433293d Don't bother preserving authored colors for canvas. r=tlouw
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
Blocks: speedometer3
Whiteboard: [sp3:proxx-tables-canvas]
Whiteboard: [sp3:proxx-tables-canvas] → [sp3-proxx-tables-canvas]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: