1798956 - Pocket newtab ensure spocs clear if turning off topsites and spocs are enabled

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement)

Description

[Scott [:thecount] Downe]

We want to make sure in cases where it is applied, turning off spocs clears any appropriate data. The spocs being used in topsites makes this a bit more complicated, and I think we can make this better.

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1798956 - Pocket newtab ensure we clear spocs in cases where sponsored topsites applies to Pocket data.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a87322f94085
Pocket newtab ensure we clear spocs in cases where sponsored topsites applies to Pocket data. r=nanj

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a87322f94085

Comment 4

[Scott [:thecount] Downe]

[Tracking Requested - why for this release]: Ideally we have this for 108 for an upcoming experiment.

Comment 5

[Scott [:thecount] Downe]

Comment on attachment 9303355 [details]
Bug 1798956 - Pocket newtab ensure we clear spocs in cases where sponsored topsites applies to Pocket data.

Beta/Release Uplift Approval Request

• User impact if declined: Impact to an experiment
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Regression testing on toggling sponsored topsites and Pocket on and off should work as expected.
• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): This might be medium low, the logic changes themselves are pretty small, and most of the changes are actually in test files.

I think at worst this is a medium risk

• String changes made/needed: None
• Is Android affected?: No

Comment 6

[Donal Meehan [:dmeehan]]

Comment on attachment 9303355 [details]
Bug 1798956 - Pocket newtab ensure we clear spocs in cases where sponsored topsites applies to Pocket data.

Approved for 108.0b6.

Comment 7

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b2f9a87ed945

Comment 8

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly 109.0a1 build (Build ID: 20221128094337) and the latest Beta 108.0b7 (Build ID: 20221127190117) on Windows 10 x64, macOS 12.4 and Linux Mint 20.

• When enabling/disabling the "Sponsored shortcuts" option the Sponsored tiles, are correctly displayed/not displayed.