Closed
Bug 1799100
Opened 2 years ago
Closed 2 years ago
Optimize string concat with null/undefined
Categories
(Core :: JavaScript Engine: JIT, task, P3)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
108 Branch
| Tracking | Status | |
|---|---|---|
| firefox108 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
(Whiteboard: [sp3])
Attachments
(2 files)
Speedometer has a bunch of Add operations where one side is a string and the other null or undefined. It's very easy to optimize this in CacheIR.
|
Assignee | |
Comment 1•2 years ago
|
||
This is a bit simpler and makes it easier to support additional types in the next patch.
|
|
Assignee | |
Comment 2•2 years ago
|
||
Speedometer 2 has both of these cases.
Depends on D161255
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9d052badcbe3
part 1 - Move number/boolean handling into tryAttachStringConcat. r=iain
https://hg.mozilla.org/integration/autoland/rev/0831084f0324
part 2 - Optimize string concat with null/undefined in CacheIR. r=iain
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9d052badcbe3
https://hg.mozilla.org/mozilla-central/rev/0831084f0324
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox108:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
|
||
Comment 5•2 years ago
•
|
||
Edit: commented on wrong bug
|
||
Updated•2 years ago
|
Whiteboard: [sp3]
|
||
Updated•2 years ago
|
See Also: → https://mozilla-hub.atlassian.net/browse/SP3-198
You need to log in
before you can comment on or make changes to this bug.
Description
•