Open Bug 1799120 Opened 2 years ago Updated 2 years ago

WebRequest.jsm uses newChannel.originalURI in onChannelReplaced, which is unreliable according to nsIChannelEventSink.idl

Categories

(WebExtensions :: Request Handling, task, P3)

Product:
WebExtensions
Component:
Request Handling
Type:
task

Tracking

(Not tracked)

People

(Reporter: robwu, Unassigned)

References

Details

newChannel.originalURI is used in WebRequest.jsm's onChannelReplaced (called by asyncOnChannelRedirect), but the IDL file claims that originalURI is unusable at that time:

     * NOTE: originalURI isn't yet set on the new channel when
     * asyncOnChannelRedirect is called.

This comment was added in bug 1732250. Either the implementation of webRequest.onBeforeRedirect is wrong, or the IDL file comment is wrong. We have a few unit tests for webRequest.onBeforeRedirect in https://searchfox.org/mozilla-central/rev/eddb810ffd5499f0984123fe4bfea6064ebad3c8/toolkit/components/extensions/test/xpcshell/test_ext_redirects.js, and should confirm whether the test coverage is complete, and if not, fix any bugs that we encounter while test coverage is expanded.

Severity: -- → N/A
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.