Closed Bug 1799193 Opened 2 years ago Closed 2 years ago

Refactor XUL nsTextBoxFrame and nsTreeBodyFrame to share string-cropping implementation

Categories

(Core :: XUL, task)

task

Tracking

()

RESOLVED FIXED
108 Branch
Tracking Status
firefox108 --- fixed

People

(Reporter: jfkthame, Assigned: jfkthame)

References

(Regressed 1 open bug)

Details

Attachments

(1 file)

As a followup to bug 1799093, it'd make sense to factor out the main string-cropping functionality into a shared helper for both textbox titles and treeview-cell contents to use.

This shouldn't change any behavior, it just refactors the code to use a shared string-cropping function.

It's still an approximation, and theoretically could be quite inaccurate in the case of complex text shaping,
but in practice is "good enough" for the kind of UI-element display where we use it.

Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8f567b0909e9 Refactor XUL textbox-label/treeview-cell cropping to share code. r=emilio
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
Regressions: 1925828
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: