1799197 - [wpt-sync] Sync PR 36824 - Introduce NavigationActivationState

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 36824 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36824
Details from upstream follow.

Nate Chapin <[e-mail]> wrote:

Introduce NavigationActivationState

This is a rename and generalization of CloseWatcher's existing logic for
tracking user activation so that it can be shared with the Navigation
API in a future CL.

Change-Id: I121721732c8893e15f63bd2fb2a772244d7d8acf
Reviewed-on: https://chromium-review.googlesource.com/4003812
WPT-Export-Revision: 96d3c631c3b21e34aab4c451cabb0b80686211f5

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=087d4464d44d25822d76076f478cd4453aa49613

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 16 subtests

Status Summary

Firefox

OK : 1
FAIL: 16

Chrome

OK : 1
FAIL: 16

Safari

OK : 1
FAIL: 16

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /close-watcher/user-activation.html [wpt.fyi]
  • CloseWatchers created without user activation, but close()d via user activation, fires cancel: FAIL (Chrome: FAIL, Safari: FAIL)
  • CloseWatchers created without user activation, but close()d via user activation, fires cancel, which can be preventDefault()ed: FAIL (Chrome: FAIL, Safari: FAIL)
  • CloseWatchers created without user activation, but closed via a close signal after user activation, fires cancel: FAIL (Chrome: FAIL, Safari: FAIL)
  • CloseWatchers created without user activation, but closed via a close signal after user activation, fires cancel, which can be preventDefault()ed: FAIL (Chrome: FAIL, Safari: FAIL)
  • Multiple CloseWatchers created without user activation close together (with no cancel): FAIL (Chrome: FAIL, Safari: FAIL)
  • Creating a CloseWatcher from user activation keeps it separate from the free CloseWatcher, but they don't fire cancel: FAIL (Chrome: FAIL, Safari: FAIL)
  • Creating a CloseWatcher from user activation, and close()ing CloseWatchers with user activation, fires cancel: FAIL (Chrome: FAIL, Safari: FAIL)
  • Creating a CloseWatcher from user activation, and closing CloseWatchers with a close signal after user activation, fires cancel: FAIL (Chrome: FAIL, Safari: FAIL)
  • Multiple CloseWatchers created with user activation close in reverse order: FAIL (Chrome: FAIL, Safari: FAIL)
  • 3 user activations let you have 3 + 1 = 4 ungrouped close watchers/0 cancel events: FAIL (Chrome: FAIL, Safari: FAIL)
  • 3 user activations let you have 2 close watchers with 1 cancel event, even if the first cancel event is prevented: FAIL (Chrome: FAIL, Safari: FAIL)
  • destroy()ing the free CloseWatcher allows a new free one to be created without user activation, and it receives the close signal: FAIL (Chrome: FAIL, Safari: FAIL)
  • close()ing the free CloseWatcher allows a new free one to be created without user activation, and it receives the close signal: FAIL (Chrome: FAIL, Safari: FAIL)
  • closing the free CloseWatcher via a close signal allows a new free one to be created without user activation, and it receives a second close signal: FAIL (Chrome: FAIL, Safari: FAIL)
  • The second watcher can be the free watcher, if the first is created with user activation: FAIL (Chrome: FAIL, Safari: FAIL)
  • The third watcher can be the free watcher, if the first two are created with user activation: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a7771199e62
[wpt PR 36824] - Introduce HistoryUserActivationState, a=testonly

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8a7771199e62