1799204 - [CtW] Layout table status fails to update for HTML attr changes

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Morgan Reschenberg [:morgan]]

In working on the mac test failures, I discovered this (accessible/tests/browser/mac/browser_tables.js is a good test for this)

Some HTML attributes (ie. summary, abbr, headers) affect whether we classify the table as a layout table or a data table. We queue a CacheDomain::Table update when a relevant attribute is modified or added, but we currently queue that update using this instead of the table this belongs to. Because we only push layout table status on tables the queued update doesn't actually change the status we cache in parent 😬

We already fixed this for style changed events :)

Comment 1

[Morgan Reschenberg [:morgan]]

oh also, we don't currently queue a table cache update when the summary attribute on a table changes. we should do that too.

Comment 2

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1799204: Update cached layout_guess when relevant HTML attr changes are obseved r?Jamie

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/835a66221d99
Update cached layout_guess when relevant HTML attr changes are obseved r=Jamie

Comment 4

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures on browser_table.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | accessible/tests/browser/mac/browser_table.js | Table role correct after change - Got undefined, expected "AXGroup"

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/634dafa6f84b
Update cached layout_guess when relevant HTML attr changes are obseved r=Jamie

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/634dafa6f84b