1799230 - Use Non-Transitive R Classes for Android Components

Status: RESOLVED FIXED

(Fenix :: General, task)

Description

[fice-t]

Steps to reproduce:

According to Android documentation:

You should use non-transitive R classes to have faster builds for applications with multiple modules. Doing so helps prevent resource duplication by ensuring that each module's R class only contains references to its own resources, without pulling references from its dependencies. This leads to faster builds and the corresponding benefits of compilation avoidance.

Full clean build before (./gradlew --profile --rerun-tasks assembleDebug): ~14m 50s
Full clean build after (./gradlew --profile --rerun-tasks assembleDebug): ~12m 30s

I didn't test incremental compilation, but it should show stronger results on changes to modules that have resources that aren't used by (many) other modules.

This also appears to decrease the apk size of Fenix by ~1MB.

Related PR: https://github.com/mozilla-mobile/firefox-android/pull/92

Comment 1

[BMO Automation]

Attachment: GitHub Pull Request

Comment 2

[BMO Automation]

Attachment: CI for Bug 1799230 - Use Non-Transitive R Classes

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

Release Note Request (optional, but appreciated)
[Why is this notable]: Add to Community Contributions section for Android
[Affects Firefox for Android]: only
[Suggested wording]:
[Links (documentation, blog post, etc)]:

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://github.com/mozilla-mobile/firefox-android/commit/7c88e952d0f3e416231ddf75a1a5f5ee3ad746c5

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0b2a0a76395
Use Non-Transitive R Classes