Closed Bug 1799237 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 36828 - FSA: Do not overwrite on move()

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox108 fixed)

RESOLVED FIXED
108 Branch
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36828 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36828
Details from upstream follow.

Austin Sullivan <asully@chromium.org> wrote:

FSA: Do not overwrite on move()

Before: moving over another a path which exists overwites the target
After: moving over another a path which exists results in an
InvalidModificationError

Behavior was changed here:
https://github.com/web-platform-tests/wpt/commit/b20e8343ce5ff1eada39dc1487b8b28ed903fff6#

Bug: 1366652, 1381621
Change-Id: Iffdf80522b62036264add6cacf45ba06abd788f6

Reviewed-on: https://chromium-review.googlesource.com/3930658
WPT-Export-Revision: a701ab23b909f8feeb867b06f6c2be381a95897d

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 21 subtests

Status Summary

Firefox

OK : 2
FAIL: 42

Chrome

OK : 2
PASS: 36
FAIL: 6

Safari

OK : 2
FAIL: 42

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /fs/FileSystemFileHandle-move.https.any.html [wpt.fyi]
    • move(name) to rename a file: FAIL (Chrome: PASS, Safari: FAIL)
    • get a handle to a moved file: FAIL (Chrome: PASS, Safari: FAIL)
    • move(name) to rename a file the same name: FAIL (Chrome: PASS, Safari: FAIL)
    • move("") to rename a file fails: FAIL (Chrome: PASS, Safari: FAIL)
    • move(name) can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
    • move(name) with a name with a trailing period should fail: FAIL (Chrome: PASS, Safari: FAIL)
    • move(name) with a name with invalid characters should fail: FAIL (Chrome: PASS, Safari: FAIL)
    • move(name) while the file has an open writable fails: FAIL (Chrome: PASS, Safari: FAIL)
    • move(name) while the destination file has an open writable fails: FAIL (Chrome: FAIL, Safari: FAIL)
    • move(dir, name) to rename a file: FAIL (Chrome: PASS, Safari: FAIL)
    • move(dir, name) to rename a file the same name: FAIL (Chrome: PASS, Safari: FAIL)
    • move(dir) to move a file to a new directory: FAIL (Chrome: PASS, Safari: FAIL)
    • move(dir, "") to move a file to a new directory fails: FAIL (Chrome: PASS, Safari: FAIL)
    • move(dir, name) to move a file to a new directory: FAIL (Chrome: PASS, Safari: FAIL)
    • move(dir) can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
    • move(dir, name) can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
    • move(dir, name) with a name with invalid characters should fail: FAIL (Chrome: PASS, Safari: FAIL)
    • move(dir) while the file has an open writable fails: FAIL (Chrome: PASS, Safari: FAIL)
    • move(dir, name) while the file has an open writable fails: FAIL (Chrome: PASS, Safari: FAIL)
    • move(dir) while the destination file has an open writable fails: FAIL (Chrome: FAIL, Safari: FAIL)
    • move(dir, name) while the destination file has an open writable fails: FAIL (Chrome: FAIL, Safari: FAIL)
  • /fs/FileSystemFileHandle-move.https.any.worker.html [wpt.fyi]
    • move(name) to rename a file: FAIL (Chrome: PASS, Safari: FAIL)
    • get a handle to a moved file: FAIL (Chrome: PASS, Safari: FAIL)
    • move(name) to rename a file the same name: FAIL (Chrome: PASS, Safari: FAIL)
    • move("") to rename a file fails: FAIL (Chrome: PASS, Safari: FAIL)
    • move(name) can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
    • move(name) with a name with a trailing period should fail: FAIL (Chrome: PASS, Safari: FAIL)
    • move(name) with a name with invalid characters should fail: FAIL (Chrome: PASS, Safari: FAIL)
    • move(name) while the file has an open writable fails: FAIL (Chrome: PASS, Safari: FAIL)
    • move(name) while the destination file has an open writable fails: FAIL (Chrome: FAIL, Safari: FAIL)
    • move(dir, name) to rename a file: FAIL (Chrome: PASS, Safari: FAIL)
    • move(dir, name) to rename a file the same name: FAIL (Chrome: PASS, Safari: FAIL)
    • move(dir) to move a file to a new directory: FAIL (Chrome: PASS, Safari: FAIL)
    • move(dir, "") to move a file to a new directory fails: FAIL (Chrome: PASS, Safari: FAIL)
    • move(dir, name) to move a file to a new directory: FAIL (Chrome: PASS, Safari: FAIL)
    • move(dir) can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
    • move(dir, name) can be called multiple times: FAIL (Chrome: PASS, Safari: FAIL)
    • move(dir, name) with a name with invalid characters should fail: FAIL (Chrome: PASS, Safari: FAIL)
    • move(dir) while the file has an open writable fails: FAIL (Chrome: PASS, Safari: FAIL)
    • move(dir, name) while the file has an open writable fails: FAIL (Chrome: PASS, Safari: FAIL)
    • move(dir) while the destination file has an open writable fails: FAIL (Chrome: FAIL, Safari: FAIL)
    • move(dir, name) while the destination file has an open writable fails: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/21c0c2cd02e5 [wpt PR 36828] - FSA: Do not overwrite on move(), a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.