1799383 - CSS media simulation not applied throughout navigation history

Status: VERIFIED FIXED

(DevTools :: General, defect, P3)

Description

[Brendon]

Steps to reproduce:

1. Open any webpage using CSS media queries.

• e.g. https://ed7n.github.io/pages/child-template.

2. Open DevTools > Inspector.
3. Enable any media simulation.

• e.g. print.

4. Go to some other webpage (simulation should preserve).
5. Disable all media simulations.
6. Go back one page.
7. Oops.

Actual results:

Previous media simulations are preserved.

Expected results:

Media simulations applied to the webpage should match those of the toggle buttons.

Comment 1

[Brendon]

If useful, here are the steps to a user workaround:
8. Close then open DevTools again.
9. Turn the previous simulations on, then off. The webpage should return to normal.

Comment 2

[Brendon]

Oops. I forgot to write that this bug is found in Firefox 102.4.0esr.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::CSS Parsing and Computation' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 4

[Jonathan Kew [:jfkthame]]

Yes, I can reproduce this. It seems like it might be more of a DevTools issue than the CSS engine, though; like it's failing to apply the correct media simulation settings when going back to a cached page. Moving to DevTools component for consideration.

Comment 5

[Julian Descottes [:jdescottes]]

We could try to prevent navigation while in simulation mode, or restore the default browsing context settings before doing a navigation. Although that would be annoying for other simulation modes such as dark mode.

We should first check if the browsing context's flag has been updated and if only the document retains the print mode for some reason.

Comment 6

[Julian Descottes [:jdescottes]]

The issue is in DevTools, we do not update the BrowsingContext targeted by target-configuration.
This is normally handled at https://searchfox.org/mozilla-central/rev/5a49163b7012ded5fa1c4da5aa4f8d3f7c85a5e7/devtools/server/actors/target-configuration.js#118-155, but bfcache navigations are missed.

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1799383 - [devtools] Update BrowsingContext for TargetConfiguration actor on bfcache navigation

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:Honza, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:Honza, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 10

[Julian Descottes [:jdescottes]]

Attachment: Bug 1799383 - [devtools] Restore target configuration before switching to new browsing context

Depends on D162998

Comment 11

[Julian Descottes [:jdescottes]]

Attachment: Bug 1799383 - [devtools] Do not restore configuration on discarded browsing contexts

Depends on D164217

Comment 13

[Phabricator Automation]

Comment on attachment 9307316 [details]
Bug 1799383 - [devtools] Restore target configuration before switching to new browsing context

Revision D164217 was moved to bug 1805997. Setting attachment 9307316 [details] to obsolete.

Comment 14

[Phabricator Automation]

Comment on attachment 9308570 [details]
Bug 1799383 - [devtools] Do not restore configuration on discarded browsing contexts

Revision D164846 was moved to bug 1805997. Setting attachment 9308570 [details] to obsolete.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1ddb2789d79
[devtools] Update BrowsingContext for TargetConfiguration actor on bfcache navigation r=ochameau

Comment 16

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e1ddb2789d79

Comment 17

[Brendon]

Very much appreciated.

Will look forward to this in the next ESR.

Cheers,
Brendon

Comment 18

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproduced on a 2022-12-18 Nightly build on macOS 12.
Verified as fixed on Firefox 110.0b8(build ID: 20230202190127) and Nightly 111.0a1(build ID: 20230202172003) on macOS 12, Windows 10, Ubuntu 22.