Closed
Bug 1799407
Opened 2 years ago
Closed 2 years ago
Move the definitions in FrameChildList.h/cpp into nsFrameList.h/cpp
Categories
(Core :: Layout, task)
Core
Layout
Tracking
()
RESOLVED
FIXED
108 Branch
| Tracking | Status | |
|---|---|---|
| firefox108 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
Details
Attachments
(1 file)
We have comments [1] [2] saying that putting definitions in other h/cpp solves circular dependencies, but we really can just write them in nsFrameFrame.h/cpp for simplicity.
[1] https://searchfox.org/mozilla-central/rev/3c194fa1d6f339036d2ec9516bd310c6ad612859/layout/generic/nsFrameList.h#332
[2] https://searchfox.org/mozilla-central/rev/3c194fa1d6f339036d2ec9516bd310c6ad612859/layout/generic/FrameChildList.h#19
|
Assignee | |
Comment 1•2 years ago
|
||
There shouldn't be any circular dependency that requires putting definitions in
FrameChildList.h/cpp.
|
||
Updated•2 years ago
|
Assignee: nobody → aethanyc
Status: NEW → ASSIGNED
Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c5d97a474aeb
Move definitions in FrameChildList.h/cpp into nsFrameList.h/cpp. r=emilio
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox108:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•