1799421 - Avoid asyncLoadDB to run late in shutdown

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P3)

Description

[Jens Stutte [:jstutte]]

The pref extensions.pendingOperations is writtent late during shutdown, asyncLoadDB probably should check for shutdown?

Comment 1

[Jens Stutte [:jstutte]]

Attachment: Bug 1799421 - Avoid late instantiation of XPIProvider and XPIDatabase. r?zombie

PIProvider already uses AsyncShutdown.quitApplicationGranted to start its shutdown. But it should also check to not be instantiated anymore after we passed that barrier. And XPIDatabase should check XPIProvider for shutdown beofre attempting to load a database, too., too.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8699d44117a
Avoid late instantiation of XPIProvider and XPIDatabase. r=zombie,rpl

Comment 3

[Marian-Vasile Laza]

Backed out changeset e8699d44117a (Bug 1799421) for marionette failures on nsDebugImpl.cpp.
Backout link
Push with failures <--> Mn
Failure Log

Comment 4

[Jens Stutte [:jstutte]]

Yeah, apparently asyncLoadDB needs to do

lazy.XPIInternal.resolveDBReady(this._dbPromise);

before returning in order to not block.

But the interesting piece is that we hit this at all in CI. I assume that indicates that the AddonManager can be starting late in shutdown. That reminds me of bug 1814104. If the test passes now we can probably file a new bug for this (or even ignore it).

Comment 5

[Jens Stutte [:jstutte]]

Hopefully that regression will be addressed by the latest change, too.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9bf00b9d7ae
Avoid late instantiation of XPIProvider and XPIDatabase. r=zombie,rpl

Comment 7

[Jens Stutte [:jstutte]]

Attachment: Bug 1799421 - Amend test_shutdown_barriers.js to check resolveDBReady. r?rpl

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8943596657f
Amend test_shutdown_barriers.js to check resolveDBReady. r=rpl

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a9bf00b9d7ae

Comment 10

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/e8943596657f