1799471 - Replace the toggles in about:preferences with fx-toggle

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task)

Description

[Hanna Jones [:hjones]]

The fx suggest section of about:preferencs makes use of toggle inputs. We should replace these with the new fx-toggle element.

To get this to work like the existing toggle we will need to make some changes to preferencesBindings.js so that clicking on an fx-toggle with a preference attr triggers a pref change.

Comment 1

[Hanna Jones [:hjones]]

Attachment: Bug 1799471 - Part 1: add description slot to moz-toggle r=tgiles

This patch updates moz-toggle to accept a description slot that can be used to change the description markup in cases where we need to display a support link or some other content.

I'm not totally convinced using a slot is the right approach since it might be making the toggle markup a little too configurable. One alternative is we could accept another property that we use to append a support link to the description, but I don't love that either. I don't want our components sprouting tons of properties to handle edge cases. Open to thoughts/feedback on this.

Comment 2

[Hanna Jones [:hjones]]

Attachment: Bug 1799471 - Part 2: replace toggles in about:preferences with moz-toggle r=#settings-reviewers,tgiles

This patch changes the Firefox Suggest preference toggles to use the new moz-toggle element.

For testing purposes, set browser.urlbar.quicksuggest.enabled to true to make the toggles visible in about:preferences#privacy.

Depends on D167880

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9994b5813a9f
Part 1: add description slot to moz-toggle r=tgiles,mstriemer
https://hg.mozilla.org/integration/autoland/rev/602aa16c20d4
Part 2: replace toggles in about:preferences with moz-toggle r=tgiles,mconley

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/9994b5813a9f
https://hg.mozilla.org/mozilla-central/rev/602aa16c20d4