1799497 - Error "CustomizeMode: Widget with id add-ons-button does not return a valid node" when entering customize mode

Status: VERIFIED FIXED

(WebExtensions :: General, defect)

Description

[:Gijs (he/him)]

STR:

1. open nightly
2. right click toolbar
3. click "customize toolbar..."
4. check browser console / stderr on local build

ER:
no errors

AR:
errors show up:

CustomizeMode: Widget with id add-ons-button does not return a valid node

Comment 1

[William Durand [:willdurand]]

Not sure what's missing here, this widget shouldn't be created in Nightly (because the extensions.unifiedExtensions.enabled pref is set to true by default) and we have this widget definition: https://searchfox.org/mozilla-central/rev/3c194fa1d6f339036d2ec9516bd310c6ad612859/browser/components/customizableui/CustomizableWidgets.jsm#300-314.

Maybe an old reference (id) to this widget is stored somewhere? I'll check.

Comment 2

[:Gijs (he/him)]

The stack is:

makePaletteItem (resource:///modules/CustomizeMode.jsm#845)
populatePalette (resource:///modules/CustomizeMode.jsm#812)
enter (resource:///modules/CustomizeMode.jsm#403)
enter (resource:///modules/CustomizeMode.jsm#444)
setTab (resource:///modules/CustomizeMode.jsm#270)
enter (resource:///modules/CustomizeMode.jsm#306)
oncommand (source-server1.conn0.source388#1)

(In reply to William Durand [:willdurand] from comment #1)

Not sure what's missing here, this widget shouldn't be created in Nightly (because the extensions.unifiedExtensions.enabled pref is set to true by default)

Looks like checking this pref in onBeforeCreated isn't something CustomizeMode supports in this way. I think the way this has worked in the past is making the addition of the widget in this list conditional on a pref, e.g. https://searchfox.org/mozilla-central/rev/3c194fa1d6f339036d2ec9516bd310c6ad612859/browser/components/customizableui/CustomizableWidgets.jsm#632-642 .

Alternatively we could try to teach CustomizeMode to be less upset about this eventuality.

Comment 3

[Alex Cornestean]

Hello,

Since the report was marked woth regressionwindow-wanted, I ran a mozregression and found this:

2022-11-08T09:58:44.415000: DEBUG : Found commit message:

Bug 1793626 - Enable unified extensions pref by default on Nightly. r=mixedpuppy

Differential Revision: https://phabricator.services.mozilla.com/D158745

Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4007caecc5ff616ed4c9ae76d8bfa218a1177444&tochange=82de653dd2d9c8e9901f18993258d91a836a1a9a

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1793626

Comment 5

[William Durand [:willdurand]]

Attachment: Bug 1799497 - Only register 'add-ons-button' widget when the unified extensions pref is disabled. r?Gijs!,rpl!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83fca7317ba9
Only register 'add-ons-button' widget when the unified extensions pref is disabled. r=Gijs,rpl

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/83fca7317ba9

Comment 8

[Alex Cornestean]

Verified as Fixed on the latest Nightly (108.0a1/20221109164728). Tested on Windows 10 x64 and Ubuntu 16.04 LTS.

On the latest version of Nightly, the error no longer shows up in the console when clicking “Customize Toolbar…”, confirming the fix.