1799665 - Make login search / add functionality more accessible and usable

Status: VERIFIED FIXED

(Firefox :: about:logins, enhancement, P3)

Comment 1

[Issam Mani [:issammani]]

Attachment: Bug 1799665 - Move filter input and add new login to top of sidebar. r=sgalich!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0e140db6004
Move filter input and add new login to top of sidebar. r=sgalich,bolsson

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest failures in browser/components/aboutlogins/tests/chrome/test_login_list.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/5e694f184bda4ee6a8dbfd6f71bac9e05a1d7c5c

Push with failures

Failure log

TEST-UNEXPECTED-FAIL | browser/components/aboutlogins/tests/chrome/test_login_list.html | waiting for login-sort to get focus

Comment 4

[Issam Mani [:issammani]]

On it !

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b993ed2dd56c
Move filter input and add new login to top of sidebar. r=sgalich,bolsson

Comment 6

[Atila Butkovits]

Backed out for causing mochitest failures complaining about TypeError.

Backout link: https://hg.mozilla.org/integration/autoland/rev/6823e903e5ecdfa711435acd1824610d60183a83

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=duMzoROeRP-Sx4wE9Y7LoA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=b993ed2dd56caae9557ce559247a5db146d251e3

Failure log: https://treeherder.mozilla.org/logviewer?job_id=398759285&repo=autoland&lineNumber=14479

Comment 7

[Issam Mani [:issammani]]

Interesting ! I thought I fixed all the failures. I will investigate further and land again.

Comment 8

[Issam Mani [:issammani]]

Attachment: Bug 1799665 - Fix failing tests due to changed tab order. r=sgalich

Depends on D162061

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79a4365e5da8
Move filter input and add new login to top of sidebar. r=sgalich,bolsson
https://hg.mozilla.org/integration/autoland/rev/6264e581b620
Fix failing tests due to changed tab order. r=sgalich,mtigley

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/79a4365e5da8
https://hg.mozilla.org/mozilla-central/rev/6264e581b620

Comment 11

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this enhancement using the latest Firefox Nightly 111.0a1 (Build ID: 20230122211034) on Windows 10 x64, macOS 11.7.1, and Ubuntu 22.04 x64.

• The Search Logins input and the “+” create new login button are displayed on the top part of the Login List.