Closed Bug 1799684 Opened 2 years ago Closed 1 year ago

Provide a bouncer URL for the latest release language pack

Categories

(Release Engineering :: Release Automation: Bouncer, enhancement)

Product:
Release Engineering
Component:
Release Automation: Bouncer
Type:
enhancement

Tracking

(firefox-esr102 fixed, firefox110 fixed, firefox111 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox-esr102 --- fixed
firefox110 --- fixed
firefox111 --- fixed

People

(Reporter: mkaply, Assigned: jcristau)

References

Details

Attachments

(6 files, 3 obsolete files)

Bug 1799684 - add bouncer entries for langpacks
48 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
pascalc
: approval-mozilla-esr102+
Details | Review
Bug 1799684 - add bouncer-check support for beta langpacks. r?gbrown
48 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details | Review
Bug 1799684 - add bouncer-check support for release langpacks. r?gbrown
48 bytes, text/x-phabricator-request
dmeehan
: approval-mozilla-beta+
pascalc
: approval-mozilla-release+
Details | Review
Bug 1799684 - add bouncer-check support for esr langpacks. r?gbrown
48 bytes, text/x-phabricator-request
dmeehan
: approval-mozilla-esr102+
Details | Review
Bug 1799684 - bouncer-check: don't look for langpacks on win64-aarch64
48 bytes, text/x-phabricator-request
Details | Review
Bug 1799684 - create the firefox-esr-next-langpack-latest-ssl bouncer alias with 102.8.0esr.
48 bytes, text/x-phabricator-request
Details | Review

We have enterprises that want to install language packs via policy, but unfortunately there's no easy way to get the latest release language pack.

On AMO, the latest.xpi URL will point to the latest XPI uploaded which will be beta or nightly.

And on our download websites, you have to put the version in the URL, so you can't have a URL to download the "latest release" or "latest ESR" language pack.

It would be nice to have something like:

https://download.mozilla.org/?product=langpack-latest-ssl&lang=en-US

That could download a languagepack XPI.

Component: General → Release Automation: Bouncer
QA Contact: jlorenzo → jcristau

Any thoughts on how easy this would be to do?

This should be reasonably simple, ni?self so I don't forget.

Flags: needinfo?(jcristau)
Assignee: nobody → jcristau
Status: NEW → ASSIGNED
Flags: needinfo?(jcristau)

Mike, the patches here would enable URLs like https://download.mozilla.org/?product=Firefox-beta-langpack-latest-SSL&os=osx&lang=fr (and eventually the same with product=Firefox-langpack-latest-SSL and product=Firefox-esr-langpack-latest-SSL), hopefully that'll work for the described use case?

Flags: needinfo?(mozilla)

This looks perfect.

I only wish we'd stop duplicating language packs for all platforms unnecessarily :)

Flags: needinfo?(mozilla)

Comment on attachment 9313546 [details] [review]
[mozilla-releng/scriptworker-scripts] Bug 1799684 - bouncerscript: allow bouncer entries for firefox langpacks (#621)

GitHub pull request attachment was moved to bug 1812378. Setting attachment 9313546 [details] [review] to obsolete.

Attachment #9313546 - Attachment is obsolete: true
Pushed by jcristau@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6dbf405aa947
add bouncer entries for langpacks r=releng-reviewers,gbrown

https://hg.mozilla.org/mozilla-central/rev/6dbf405aa947

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox111: --- → fixed
Resolution: --- → FIXED

Is there some other change that is needed to make the bouncer URLs work?

They should start working as this rides the trains (or we can uplift to beta/esr102 if we want).

I would love to uplift this to beta/esr102 if it's low risk.

Comment on attachment 9313549 [details]
Bug 1799684 - add bouncer entries for langpacks

Beta/Release Uplift Approval Request

  • User impact if declined: enterprises don't have a version-agnostic url to use for language packs, for use in policy settings.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Adds an extra bouncer product/alias during release automation, pointing at the language packs on archive.mozilla.org. no impact on existing products/URLs/releases.
    There's a bouncer-check test as part of release automation and cron, but we can't land that patch until after a first release creates the URLs. We don't have to advertise the new URLs until after we've double checked them, though.
  • String changes made/needed:
  • Is Android affected?: No

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: enterprise-facing improvement
  • User impact if declined:
  • Fix Landed on Version: 111
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky):
Attachment #9313549 - Flags: approval-mozilla-esr102?
Attachment #9313549 - Flags: approval-mozilla-beta?

Comment on attachment 9313549 [details]
Bug 1799684 - add bouncer entries for langpacks

Approved for 110 beta 8, thanks.

Attachment #9313549 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9313550 - Attachment is obsolete: true
Attachment #9313551 - Attachment is obsolete: true
Pushed by jcristau@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8cd8d77713f4
add bouncer-check support for beta langpacks. r=gbrown DONTBUILD

Comment on attachment 9315337 [details]
Bug 1799684 - add bouncer-check support for beta langpacks. r?gbrown

Mind uplifting this a=release? It'll add a check during release promotion and in cron for the new bouncer URLs.

Attachment #9315337 - Flags: approval-mozilla-beta?
Attachment #9315337 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

win64-aarch64 is not included in beetmover's list of platforms where we copy langpacks.

Pushed by jcristau@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c1b1eb90b879
bouncer-check: don't look for langpacks on win64-aarch64 DONTBUILD

Julien, the patch doesn't graft cleanly to the esr102 branch as bug 1786291 wasn't uplifted to the ESR102 branch.

Flags: needinfo?(jcristau)
Attachment #9313549 - Flags: approval-mozilla-esr102? → approval-mozilla-esr102+
Flags: needinfo?(jcristau)

Creating the bouncer alias now means we don't have to wait until
115.0esr is shipped before adding it to bouncer-check.

This patch should land on esr102 only, and should get backed out after
102.8.0esr ships.

Comment on attachment 9315338 [details]
Bug 1799684 - add bouncer-check support for release langpacks. r?gbrown

Beta/Release Uplift Approval Request

  • User impact if declined: n/a
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): adding new langpack URLs to the daily bouncer checks
  • String changes made/needed:
  • Is Android affected?: No
Attachment #9315338 - Flags: approval-mozilla-release?

Comment on attachment 9315339 [details]
Bug 1799684 - add bouncer-check support for esr langpacks. r?gbrown

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: adding new langpack URLs to daily and per-release bouncer-check so we know if they break
  • User impact if declined: none
  • Fix Landed on Version: 112
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky):
Attachment #9315339 - Flags: approval-mozilla-esr102?
Attachment #9315338 - Flags: approval-mozilla-beta?
Pushed by jcristau@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6e79055edec7
add bouncer-check support for release langpacks. r=gbrown DONTBUILD
https://hg.mozilla.org/integration/autoland/rev/47be2ade69df
add bouncer-check support for esr langpacks. r=gbrown DONTBUILD

Comment on attachment 9315338 [details]
Bug 1799684 - add bouncer-check support for release langpacks. r?gbrown

Approved for 111.0b5

Attachment #9315338 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment on attachment 9315338 [details]
Bug 1799684 - add bouncer-check support for release langpacks. r?gbrown

Approved for 110 branch.

Attachment #9315338 - Flags: approval-mozilla-release? → approval-mozilla-release+

Comment on attachment 9315339 [details]
Bug 1799684 - add bouncer-check support for esr langpacks. r?gbrown

Approved for 102.9esr.

Attachment #9315339 - Flags: approval-mozilla-esr102? → approval-mozilla-esr102+

Backed out changeset 50febcb5a2f4 (Bug 1799684) backed out for introducing test failures
esr102 Backout link

:jcristau could you take a look?
Log: https://firefox-ci-tc.services.mozilla.com/tasks/ZZGRDDUYRQWMWJOyE9ENKQ/runs/0/logs/public/logs/live.log

status-firefox-esr102: fixed → affected
Flags: needinfo?(jcristau)

verified that cron-bouncer-check now passes on esr102: https://firefox-ci-tc.services.mozilla.com/tasks/dMQb0BPWSXCVQRYs3r156Q

And backed out the change from comment 32 on esr102 to stop updating firefox-esr-next-langpack-latest-ssl until esr115:
https://hg.mozilla.org/releases/mozilla-esr102/rev/92edc0e8bc7edbd7cae690c82ce374f58e4db138

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: