1799685 - moz-phab --wip complains about "command --wip not found"

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

The exact message is "moz-phab called without arguments; falling back to submit" and then it seems to run moz-phab submit --wip
The warning message isn't very clear, and is it needed at all? This is a recent change.

Comment 1

[:glob ✱]

:sheehan: and I were talking about this issue last night - it's fallout from the fix on bug 1740228.

We need to change the current implementation (always show the 'falling back' message) to what was requested in comment 4:

We should probably detect when we've fallen back to submit and provide a clear error message if an invalid revset is provided.

ie. remove the current message and just improve the error message when an invalid revset/range is provided.

Comment 2

[Connor Sheehan [:sheehan]]

Attachment: submit: remove "falling back to submit" messaging (Bug 1799685) r?dkl,zeid

We will move this messaging to a more relevant location in a later
commit.

Depends on D161810

Comment 5

[Connor Sheehan [:sheehan]]

Attachment: submit: add a warning when `submit` fails in fallback mode (Bug 1799685) r?dkl,zeid

Adds a try/except block around the main submit function
to print a warning message to the terminal after submit
fails when in fallback mode.

Comment 6

[Connor Sheehan [:sheehan]]

The fallback warning is more targeted now, only appearing when submit fails when run without submit on the CLI.