1799710 - Consider simplifying use of "<>" string replacement in addon consent flow

Status: NEW

(Toolkit :: Add-ons Manager, task, P3)

Description

[Bobby Holley (:bholley)]

The prompt/notification machinery has a special affordance wherein certain subsets of the header string can be designated "names", and referenced symbolically as "<>" and "{}" to receive special formatting. That code assumes that the existence of |name| and |secondName| in the options object imply the presence of "<>" and "{}" (respectively) in the string.

At present, WebExtensions use this affordance while SitePermission add-ons don't, so we need to conditionally set the |name| field in showPermissionsPrompt() in ExtensionsUI.jsm.

It appears at first glance that we the formatting of the extension name ends up identical to the rest of the string in the WebExtensions case, so we could potentially simplify this by substituting the addon name directly in formatPermissionStrings and then eliminating the handling of "<>" here entirely.