Closed Bug 1799720 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 36873 - FSA: Assert WritableFileStream throws TypeError on close() after error

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox108 fixed)

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36873 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36873
Details from upstream follow.

Austin Sullivan <asully@chromium.org> wrote:

FSA: Assert WritableFileStream throws TypeError on close() after error

This fixes a WPT that was incorrectly updated here:
https://github.com/web-platform-tests/wpt/commit/98d3176d0509007a578efbce81ce9e66a12c3c96

Relevant language in the Streams spec:
https://streams.spec.whatwg.org/#default-writer-close

Bug: 1381826
Change-Id: I93b51ae996cbefdab0ab86fdc072d83ba6c4b13f
Reviewed-on: https://chromium-review.googlesource.com/4012947
WPT-Export-Revision: 34ea006e24d18f9dd81a0e64ba557d2c0f3ade0c

PR 36873 applied with additional changes from upstream: 0872ef848702fc8097acc655e77953428bccdcc1, 98d3176d0509007a578efbce81ce9e66a12c3c96
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 30 subtests

Status Summary

Firefox

OK : 2
FAIL: 60

Chrome

OK : 2
PASS: 60

Safari

OK : 2
FAIL: 60

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /fs/FileSystemWritableFileStream-write.https.any.html [wpt.fyi]
    • write() with an empty blob to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
    • write() a blob to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
    • write() with WriteParams without position to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
    • write() a string to an empty file with zero offset: FAIL (Chrome: PASS, Safari: FAIL)
    • write() a blob to an empty file with zero offset: FAIL (Chrome: PASS, Safari: FAIL)
    • write() called consecutively appends: FAIL (Chrome: PASS, Safari: FAIL)
    • write() WriteParams without position and string appends: FAIL (Chrome: PASS, Safari: FAIL)
    • write() WriteParams without position and blob appends: FAIL (Chrome: PASS, Safari: FAIL)
    • write() called with a string and a valid offset: FAIL (Chrome: PASS, Safari: FAIL)
    • write() called with a blob and a valid offset: FAIL (Chrome: PASS, Safari: FAIL)
    • write() called with an offset beyond the end of the file: FAIL (Chrome: PASS, Safari: FAIL)
    • write() with an empty string to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
    • write() with a valid utf-8 string: FAIL (Chrome: PASS, Safari: FAIL)
    • write() with a string with unix line ending preserved: FAIL (Chrome: PASS, Safari: FAIL)
    • write() with a string with windows line ending preserved: FAIL (Chrome: PASS, Safari: FAIL)
    • write() with an empty array buffer to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
    • write() with a valid typed array buffer: FAIL (Chrome: PASS, Safari: FAIL)
    • atomic writes: close() fails when parent directory is removed: FAIL (Chrome: PASS, Safari: FAIL)
    • atomic writes: writable file streams make atomic changes on close: FAIL (Chrome: PASS, Safari: FAIL)
    • atomic writes: write() after close() fails: FAIL (Chrome: PASS, Safari: FAIL)
    • atomic writes: truncate() after close() fails: FAIL (Chrome: PASS, Safari: FAIL)
    • atomic writes: close() after close() fails: FAIL (Chrome: PASS, Safari: FAIL)
    • atomic writes: only one close() operation may succeed: FAIL (Chrome: PASS, Safari: FAIL)
    • atomic writes: writable file stream persists file on close, even if file is removed: FAIL (Chrome: PASS, Safari: FAIL)
    • getWriter() can be used: FAIL (Chrome: PASS, Safari: FAIL)
    • WriteParams: truncate missing size param: FAIL (Chrome: PASS, Safari: FAIL)
    • WriteParams: write missing data param: FAIL (Chrome: PASS, Safari: FAIL)
    • WriteParams: write null data param: FAIL (Chrome: PASS, Safari: FAIL)
    • WriteParams: seek missing position param: FAIL (Chrome: PASS, Safari: FAIL)
    • write() with an invalid blob to an empty file should reject: FAIL (Chrome: PASS, Safari: FAIL)
  • /fs/FileSystemWritableFileStream-write.https.any.worker.html [wpt.fyi]
    • write() with an empty blob to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
    • write() a blob to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
    • write() with WriteParams without position to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
    • write() a string to an empty file with zero offset: FAIL (Chrome: PASS, Safari: FAIL)
    • write() a blob to an empty file with zero offset: FAIL (Chrome: PASS, Safari: FAIL)
    • write() called consecutively appends: FAIL (Chrome: PASS, Safari: FAIL)
    • write() WriteParams without position and string appends: FAIL (Chrome: PASS, Safari: FAIL)
    • write() WriteParams without position and blob appends: FAIL (Chrome: PASS, Safari: FAIL)
    • write() called with a string and a valid offset: FAIL (Chrome: PASS, Safari: FAIL)
    • write() called with a blob and a valid offset: FAIL (Chrome: PASS, Safari: FAIL)
    • write() called with an offset beyond the end of the file: FAIL (Chrome: PASS, Safari: FAIL)
    • write() with an empty string to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
    • write() with a valid utf-8 string: FAIL (Chrome: PASS, Safari: FAIL)
    • write() with a string with unix line ending preserved: FAIL (Chrome: PASS, Safari: FAIL)
    • write() with a string with windows line ending preserved: FAIL (Chrome: PASS, Safari: FAIL)
    • write() with an empty array buffer to an empty file: FAIL (Chrome: PASS, Safari: FAIL)
    • write() with a valid typed array buffer: FAIL (Chrome: PASS, Safari: FAIL)
    • atomic writes: close() fails when parent directory is removed: FAIL (Chrome: PASS, Safari: FAIL)
    • atomic writes: writable file streams make atomic changes on close: FAIL (Chrome: PASS, Safari: FAIL)
    • atomic writes: write() after close() fails: FAIL (Chrome: PASS, Safari: FAIL)
    • atomic writes: truncate() after close() fails: FAIL (Chrome: PASS, Safari: FAIL)
    • atomic writes: close() after close() fails: FAIL (Chrome: PASS, Safari: FAIL)
    • atomic writes: only one close() operation may succeed: FAIL (Chrome: PASS, Safari: FAIL)
    • atomic writes: writable file stream persists file on close, even if file is removed: FAIL (Chrome: PASS, Safari: FAIL)
    • getWriter() can be used: FAIL (Chrome: PASS, Safari: FAIL)
    • WriteParams: truncate missing size param: FAIL (Chrome: PASS, Safari: FAIL)
    • WriteParams: write missing data param: FAIL (Chrome: PASS, Safari: FAIL)
    • WriteParams: write null data param: FAIL (Chrome: PASS, Safari: FAIL)
    • WriteParams: seek missing position param: FAIL (Chrome: PASS, Safari: FAIL)
    • write() with an invalid blob to an empty file should reject: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f321322f59cd [wpt PR 36873] - FSA: Assert WritableFileStream throws TypeError on close() after error, a=testonly https://hg.mozilla.org/integration/autoland/rev/3b40004f3d32 [wpt PR 36873] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/f321322f59cd
https://hg.mozilla.org/mozilla-central/rev/3b40004f3d32

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.