1799947 - browser_action's without a valid default_area set should fallback to using AREA_ADDONS when Unified Extensions UI is enabled

Status: RESOLVED FIXED

(WebExtensions :: Frontend, enhancement, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

By default, up until now, if a WebExtension with a browser_action has not supplied a default_area, we've fallen back to putting the browser_action into the navbar.

With the Unified Extensions UI enabled, we want to change that fallback behaviour so that browser_actions with a default_area get added to the addons panel instead.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

We should also take the opportunity to update the documentation at https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/browser_action about this.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1799947 - With Unified Extensions UI, make addons panel the fallback area for browser_actions. r?willdurand!

Depends on D161338

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1799947 - Update existing tests to put browser_action's into the navbar by default. r?willdurand!

We had a number of tests that assumed that when adding a browser_action without
specifying the default_area, that the button would enter the navbar. The previous
patch in this series changes that assumption when the Unified Extensions UI is
enabled.

Instead of updating all of these tests to add additional steps to move the
browser_action's out to the navbar after adding them, I've gone ahead and
updated them to default their browser_action's to the navbar instead.

Depends on D161720

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/517df40ddcd4
With Unified Extensions UI, make addons panel the fallback area for browser_actions. r=willdurand
https://hg.mozilla.org/integration/autoland/rev/ff58300200c4
Update existing tests to put browser_action's into the navbar by default. r=willdurand,extension-reviewers

Comment 5

[Marian-Vasile Laza]

Backed out 2 changesets (Bug 1799947) for causing multiple browserAction bc, mochitest, devtools related failures.
Backout link
Push with failures <--> bc1 <--> 6 <--> dt4
Failure Log
Also 6 Failure Log
Also dt4 Failure Log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33884422a0a4
With Unified Extensions UI, make addons panel the fallback area for browser_actions. r=willdurand
https://hg.mozilla.org/integration/autoland/rev/4f0d86227850
Update existing tests to put browser_action's into the navbar by default. r=willdurand,extension-reviewers

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/33884422a0a4
https://hg.mozilla.org/mozilla-central/rev/4f0d86227850

Comment 8

[jscher2000]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #1)

We should also take the opportunity to update the documentation at https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/browser_action about this.

I created an issue for the dev doc: https://github.com/mdn/content/issues/23797

Comment 9

[William Durand [:willdurand]]

I noticed the inaccuracy in the MDN docs so I submitted a patch.