1800060 - [CTW] LINKS_TO should return early if there's no hash and shouldn't strip subsequent hashes

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[James Teh [:Jamie]]

I should have caught this in review, but I didn't. :(

The LINKS_TO code in RemoteAccessibleBase splits the href string at '#' and takes the last segment. There are two problems with this:

1. If there is no '#' in the href, it will just use the entire href. It should instead return early, since there's no point in searching the tree if there's no hash. This should improve performance slightly for the majority of links.
2. It's technically possible to have more than one '#' in the href. In that case, the code will only use the text between the two '#' characters instead of looking at everything after the first '#'. Consider this example (%23 is '#'):
   data:text/html,<a href="%23foo%23bar">Origin</a><br><a name="foo%23bar">Destination
   The current code will not find this target. I doubt this really happens in the wild, so it's not particularly important.

I think we might want to use FindChar instead of Split.

Comment 1

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1800060: Avoid computing LINKS_TO for links with no anchor r?Jamie

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ae07702fe68
Avoid computing LINKS_TO for links with no anchor r=Jamie

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/2ae07702fe68