1800132 - Add webrtc lib related debug frames to irrelevant list

Status: RESOLVED FIXED

(Socorro :: Signature, task, P2)

Description

[Jim Mathies [:jimm]]

We'd like to request that a set of frames associated with fatal error handling in libwebrtc be skipped in signature processing such that we get better visibility of issues on crashstats.

example reports:
https://crash-stats.mozilla.org/report/index/cf98f86b-bc73-420a-8b47-577030221110
https://crash-stats.mozilla.org/report/index/b75873e4-747e-44d1-8b68-2cfcb0221110
all the top frames down to and including FatalLogCall should be skipped.

example of how these get aggregated -
https://crash-stats.mozilla.org/search/?topmost_filenames=~webrtc&date=%3E%3D2022-11-03T18%3A39%3A00.000Z&date=%3C2022-11-10T18%3A39%3A00.000Z&_facets=signature&_facets=process_type&_sort=-date&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-signature

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

This is pretty straightforward to do. There's documentation here:

• https://socorro.readthedocs.io/en/latest/signaturegeneration.html#how-to-make-a-signature-generation-change
• https://github.com/mozilla-services/socorro/tree/main/socorro/signature

I can probably get to it late next week if no one gets to it first.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Jim: Are you looking for something like this?

app@socorro:/app$ socorro-cmd signature cf98f86b-bc73-420a-8b47-577030221110
Crash id: cf98f86b-bc73-420a-8b47-577030221110
Original: wil::details::DebugBreak
New:      wil::details::DebugBreak | (anonymous namespace)::WriteFatalLogAndAbort | rtc::webrtc_checks_impl::FatalLog | rtc::webrtc_checks_impl::LogStreamer<T>::CallCheckOp
Same?:    False

Comment 3

[Jim Mathies [:jimm]]

Can we get all the way down to webrtc::RtpPacketizerH264::PacketizeStapA and webrtc::AlignedMalloc?

https://crash-stats.mozilla.org/report/index/cf98f86b-bc73-420a-8b47-577030221110
https://crash-stats.mozilla.org/report/index/b75873e4-747e-44d1-8b68-2cfcb0221110

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

The signature gets too long and gets truncated if we keep all those frames in it.

Here's the stack for cf98f86b-bc73-420a-8b47-577030221110:

wil::details::DebugBreak
(anonymous namespace)::WriteFatalLogAndAbort
rtc::webrtc_checks_impl::FatalLog
rtc::webrtc_checks_impl::LogStreamer<T>::CallCheckOp
rtc::webrtc_checks_impl::LogStreamer<T>::CallCheckOp
rtc::webrtc_checks_impl::LogStreamer<T>::CallCheckOp
rtc::webrtc_checks_impl::FatalLogCall<T>::operator&
webrtc::RtpPacketizerH264::PacketizeStapA
webrtc::RtpPacketizerH264::GeneratePackets
...

Can you indicate which frames you want in the signature and which ones aren't meaningful and should be omitted from the signature?

Comment 5

[Gabriele Svelto [:gsvelto]]

I can handle this one

Comment 6

[Gabriele Svelto [:gsvelto]]

Attachment: pr 6284: Bug 1800132 - Tweaked signature generation for WebRTC crashes

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #6284: "Bug 1800132 - Tweaked signature generation for WebRTC crashes" in 3b8d01d.

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

This was pushed to prod in bug #1804294. Marking as FIXED.