Closed Bug 1800294 Opened 3 years ago Closed 3 years ago

Expect constexpr constructor error when compiling as C++17 but not C++20

Categories

(Developer Infrastructure :: Source Code Analysis, task, P3)

Unspecified
All

Tracking

(firefox109 fixed)

RESOLVED FIXED
Tracking Status
firefox109 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

C++20 allows non-trivial constexpr constructors, so this BadUnfortunateError check passes unexpectedly when compiled as C++20:

error: 'error' diagnostics expected but not seen: build/clang-plugin/tests/TestTrivialCtorDtor.cpp Line 81: class 'BadUnfortunateError' must have trivial constructors and destructors

This constexpr constructor check was added in bug 1226376.

C++20 allows non-trivial constexpr constructors, so this BadUnfortunateError check passes unexpectedly when compiled as C++20:

error: 'error' diagnostics expected but not seen: build/clang-plugin/tests/TestTrivialCtorDtor.cpp Line 81: class 'BadUnfortunateError' must have trivial constructors and destructors

This constexpr constructor check was added in bug 1226376.

Pushed by cpeterson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e41a02612369 clang-plugin: expect constexpr constructor error when compiling as C++17 but not C++20. r=firefox-static-analysis-reviewers,andi
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: