1800301 - Large percentage of time still spent in ScopedResolveTexturesForDraw after 1798929

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

I thought the fix in bug 1798929 would remove the problem, but it didn't help as much as I thought!

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1800301 - Reduce allocs and ptr-chasing in ScopedResolveTexturesForDraw.

Comment 2

[Kelsey Gilbert [:jgilbert]]

On webgl aquarium, this pushed fps in a local opt build from 24fps@30k fish to 31fps.

Comment 3

[Kelsey Gilbert [:jgilbert]]

(Edge gets 40fps)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5a6e0827824
Reduce allocs and ptr-chasing in ScopedResolveTexturesForDraw. r=gfx-reviewers,lsalzman

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for mochitest failure on WebGLContextDraw.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/8404b8ebd31cb1e784a2a1b64bf27457a5181562
Log link: https://treeherder.mozilla.org/logviewer?job_id=396362246&repo=autoland&lineNumber=1973

Comment 6

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1800301 - Reduce allocs and ptr-chasing in ScopedResolveTexturesForDraw.

• Add inlining_vector<T,N>, like AutoTArray, but using std::vector for
  familiarity and safety.

Comment 7

[Kelsey Gilbert [:jgilbert]]

Unlike std::vector::resize, AutoTArray::SetLength does not value-initialize.
This seems dangerous, but I don't want to try to fix it.

Can we just adapt std::vector to our needs, it seems like it!

Comment 8

[Kelsey Gilbert [:jgilbert]]

I was just playing with this, and it seems pretty straightforward, if clunkily phrased: https://godbolt.org/z/377rqfxKn

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/837b9d0269be
Reduce allocs and ptr-chasing in ScopedResolveTexturesForDraw. r=gfx-reviewers,lsalzman

Comment 10

[Lee Salzman [:lsalzman]]

Attachment: Bug 1800301 - Use Vector instead of custom inlining_vector. r?jgilbert

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be4f28d07be5
Use Vector instead of custom inlining_vector. r=jgilbert

Comment 12

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/837b9d0269be
https://hg.mozilla.org/mozilla-central/rev/be4f28d07be5