1800368 - Panels flicker while animating (Wayland)

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Gregory Pappas [:gregp]]

Attachment: flicker.webm

Steps to reproduce:

1. Navigate to a website
2. Click the lock icon in the address bar
3. Click the shield icon in the address bar

Actual results:
Occasional flicker

Expected results:
Normal animation

Comment 1

[Martin Stránský [:stransky] (ni? me)]

What do you mean by "animation"? Just hide/show or is there anything else?

Comment 2

[Gregory Pappas [:gregp]]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #1)

What do you mean by "animation"? Just hide/show or is there anything else?

Just the opacity/transform animation that appears during hide/show, yes.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Which compositor do you use? Please attach your about:support page.
Thanks.

Comment 4

[Gregory Pappas [:gregp]]

Attachment: about:support

(In reply to Martin Stránský [:stransky] (ni? me) from comment #3)
> Which compositor do you use? Please attach your about:support page.
> Thanks.

Comment 5

[Kestrel]

I can also reproduce this on Ubuntu 22.10 when switching from the Pocket panel to the hamburger menu. It does not happen with ui.panelAnimations = 0.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3924518919682eae3ae92f9c6da486b361e4ea80&tochange=8e9534dd0451f24dd851905af796475b61aa8e44

Regressed by Bug 1799901.

Comment 6

[Kestrel]

Attachment: Hamburger panel flickers when switching to it from Pocket panel

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1799901, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Bug 1800442 will disable these again for now.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1800368 - Disable panel animations on Wayland for regressions. r=stransky

I don't have time to dig into them right now so disable there for now.

I could repro the flickering on Arch Linux, but I couldn't repro the
incorrectly-transparent popup or the incorrectly-open extension popup...

Comment 10

[Martin Stránský [:stransky] (ni? me)]

I think the flickering here will be fixed by disabled move-to-rect popup placement. But better to disable the animations now due to Bug 1800442.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dab6d43d5a7a
Disable panel animations on Wayland for regressions. r=stransky

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/dab6d43d5a7a

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox108 to wontfix.

For more information, please visit auto_nag documentation.

Comment 14

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9303768 [details]
Bug 1800368 - Disable panel animations on Wayland for regressions. r=stransky

Beta/Release Uplift Approval Request

• User impact if declined: comment 0 and duplicate
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very targeted, restores previous behavior.
• String changes made/needed: none
• Is Android affected?: No

Comment 15

[Dianna Smith [:diannaS]]

Comment on attachment 9303768 [details]
Bug 1800368 - Disable panel animations on Wayland for regressions. r=stransky

Approved for 108.0b4

Comment 16

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/81e182862234

Comment 17

[Catalin Sasca, Desktop QA [:csasca]]

Reproduced the issue with Firefox 108.0a1 (2022-11-12) on Ubuntu 22.04 by following the info provided in Comment 0.

The issue is fixed on Firefox 108.0b4 and Firefox 109.0a1 (2022-11-20) on the same system.