1800436 - [wpt-sync] Sync PR 36955 - Re-land: Stay on the same page as long as no new page name is provided.

Status: RESOLVED FIXED

(Core :: Layout: Columns, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 36955 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36955
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:

Re-land: Stay on the same page as long as no new page name is provided.

CL:4020554 assumed that the layout result is always a successful one,
but that's not always the case. Need to check that before examining the
fragment (it will be nullptr if the result isn't successful). This
addition avoids crbug.com/1383662 - the layout result was
kOutOfFragmentainerSpace.

Original CL:4020554 commit comment follows:

We were missing a very obvious case: If the ancestry has defined a page
name, any descendant that didn't specify the same name would get a break
before it.

We were missing two things:

1. "Inherit" the page name from the ancestry, if neither the child nor
   descendants provide anything, so that we don't leave the page name
   blank when it shouldn't be.

2. When checking for a page name mismatch on a child, check the
   fragment, not the input node (because that one just checks the
   computed style of the 'page' property).

Bug: 1383166
Change-Id: Ie4a7ac75740b63972bac2f51a5218b28d0571e63
Reviewed-on: https://chromium-review.googlesource.com/4024445
WPT-Export-Revision: 8c699165ec56441ab25bf937efb84acedfa16e78

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a177404cccd7ada33cd5ef4bf38817377b20c54a

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37df95aa4ede
[wpt PR 36955] - Re-land: Stay on the same page as long as no new page name is provided., a=testonly

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/37df95aa4ede