1800482 - Consider tracking fullscreen-request-origin on browsing context of chrome window

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Edgar Chen [:edgar]]

While working on other bug, I found a possible racing on how we handle the fullscreen event of chrome document on parent process, that causes some intermittent test failures like, bug 1783816 and bug 1785951, and becomes worse after some timing changes.

It basically happens on a case that two FullscreenJSParentActors try to handle the fullscreen event fired on chrome document. And since now we track the fullscreen-request-origin on the top-level content bc, so both actors think they are the current requesting one. It is probably fine in practice as browser ends up exiting the fullscreen, but it causes the some state racing and cause the tests are not able to have a reliable way to check the state transition.

So it seems to me that we could consider move the tracking of fullscreen-request-origin to browsing context of chrome window, and the one who is not the current the fullscreen-request-origin just ignore the fullscreen event.

Comment 1

[Edgar Chen [:edgar]]

Attachment: Bug 1800482 - Track fullscreen-request-origin in top-level chrome browsing context; r?smaug

Comment 2

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&revision=898c36391200685cf558336d58ff11ffcfca5553

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03f24048822f
Track fullscreen-request-origin in top-level chrome browsing context; r=smaug

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/03f24048822f