Closed Bug 1800514 Opened 1 year ago Closed 1 year ago

Don't unbox shapes in GuardMultipleShapes

Categories

(Core :: JavaScript Engine: JIT, task, P2)

task

Tracking

()

RESOLVED FIXED
109 Branch
Tracking Status
firefox109 --- fixed

People

(Reporter: iain, Assigned: iain)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1671228 is adding GuardMultipleShapes as part of stub folding. Jan pointed out in review that instead of unboxing each element of the list of expected shapes and comparing it against the object's shape, we could box the object's shape once and compare boxed values.

I was already staring at register allocation in this function, so it seemed like a reasonable time to fix this.

Depends on D163154

Pushed by iireland@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3efc48a2f505
Don't unbox in GuardMultipleShapes r=jandem
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: