Closed Bug 1800514 Opened 4 months ago Closed 4 months ago

Don't unbox shapes in GuardMultipleShapes

Categories

(Core :: JavaScript Engine: JIT, task, P2)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
109 Branch
Project Flags:
a11y-review fixed
Performance Impact fixed
Webcompat Priority fixed
Tracking Flags:
Tracking Status
relnote-firefox --- fixed
thunderbird_esr91 fixed fixed
thunderbird_esr102 fixed fixed
firefox-esr102 fixed fixed
firefox109 --- fixed
firefox111 fixed fixed
firefox112 fixed fixed
firefox113 fixed fixed

People

(Reporter: iain, Assigned: iain)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1800514: Don't unbox in GuardMultipleShapes r=jandem
48 bytes, text/x-phabricator-request
Details | Review

Bug 1671228 is adding GuardMultipleShapes as part of stub folding. Jan pointed out in review that instead of unboxing each element of the list of expected shapes and comparing it against the object's shape, we could box the object's shape once and compare boxed values.

I was already staring at register allocation in this function, so it seemed like a reasonable time to fix this.

Depends on D163154

Pushed by iireland@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3efc48a2f505
Don't unbox in GuardMultipleShapes r=jandem

https://hg.mozilla.org/mozilla-central/rev/3efc48a2f505

Status: NEW → RESOLVED
Closed: 4 months ago
status-firefox109: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
You need to log in before you can comment on or make changes to this bug.