1800531 - Never throttle crashes involving the PHC

Status: RESOLVED FIXED

(Socorro :: Antenna, task, P2)

Description

[Gabriele Svelto [:gsvelto]]

PHC crashes are very valuable because they involve very dangerous and exploitable scenarios: buffer overruns, use-after-frees, etc... We only get a trickle of them because of the statistical nature of PHC.

Currently PHC is only enabled on nightly so related crashes are not throttled, however we want to use it more aggressively in the future, potentially shipping it in release. When that happens we should tweak the throttling logic to never throttle crashes that have the PHCKind annotation set.

There's no hurry to implement this because it's still some time off but filing this bug nonetheless so I don't forget.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

How can we know whether a crash report involves PHC?

Comment 2

[Gabriele Svelto [:gsvelto]]

They have the PHCKind annotation set, non-PHC crashes don't have it.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

I can get this done today.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 887: bug 1800531: accept all phc crash reports

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #887: "bug 1800531: accept all phc crash reports" in d5a41bf.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

I deployed this just no in bug #1800935. Marking as FIXED.