1800579 - Implement the impression event

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement)

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1800579: Implement the impression event.

Depends on D161977

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1800579: Rename engagementEvent with telemetry.

Depends on D162085

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1800579: Refactoring _recordSearchEngagementTelemetry() function.

Depends on D162085

Comment 4

[Daisuke Akatsuka (:daisuke)]

Attachment: data-review-request-for-bug1800579.md

Comment 5

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1800579: Exchange the priority for 'refined' and 'persisted_search_terms' of interaction.

In bug 1802564, we enabled browser.urlbar.showSearchTerms.featureGate on as
default in Nightly.
By the change, in case of that user searches 2 or more times
on the same browser, the search source will almost be urlbar-persisted.
In this case, the interaction value never be refined in the current
implementation since we evaluate whether the search source is urlbar-persisted
first. Therefor, change the priority so that refined value will be recorded.

Depends on D163671

Comment 6

[Megan McCorquodale]

Comment on attachment 9306514 [details]
data-review-request-for-bug1800579.md

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
   Yes, this will be documented in the Glean dictionary.

2. Is there a control mechanism that allows the user to turn the data collection on and off?
   Yes, users can opt out of telemetry collection.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?
   The search and suggest team will monitor.

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
   Category 2, interaction data.

5. Is the data collection request for default-on or default-off?
   Default on.

6. Does the instrumentation include the addition of any new identifiers?
   No new identifiers.

7. Is the data collection covered by the existing Firefox privacy notice?
   Yes.

8. Does the data collection use a third-party collection tool?
   No.

---

data-review +

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2796c110119d
Implement the impression event. r=mak,Dexter
https://hg.mozilla.org/integration/autoland/rev/329d79c6403b
Refactoring _recordSearchEngagementTelemetry() function. r=mak

Comment 8

[Cristian Tuns]

Backed out for causing mochitest failures on browser_glean_telemetry_impression_interaction.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_glean_telemetry_impression_interaction.js | 1 == 2 - JS frame :: chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/head-glean.js :: _assertGleanTelemetry :: line 42

Comment 9

[Phabricator Automation]

Comment on attachment 9306610 [details]
Bug 1800579: Exchange the priority for 'refined' and 'persisted_search_terms' of interaction.

Revision D163803 was moved to bug 1804314. Setting attachment 9306610 [details] to obsolete.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2776f942a0a4
Implement the impression event. r=mak,Dexter
https://hg.mozilla.org/integration/autoland/rev/9f1ae2ec67ac
Refactoring _recordSearchEngagementTelemetry() function. r=mak

Comment 11

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/2776f942a0a4
https://hg.mozilla.org/mozilla-central/rev/9f1ae2ec67ac