1800646 - glean-core's "metrics" ping scheduler never sends pings with reason "upgrade"

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, defect, P1)

Description

[Chris H-C :chutten]

The core MPS very cleverly checks the stored value of the app build id that last sent a "metrics" ping of reason "upgrade" and, if it's different from the current app build id, sends a new ping and sets the value.

...only problem is the first case: the core MPS doesn't set a value to that internal storage if there isn't already one in there.

This bug's about making the core MPS properly send "metrics" pings with reason "upgrade". And also ensuring we (per docs) send a ping with reason "overdue" if in fact this is the first time we've ever started since being installed.

Might be worth filing a follow-up to update notable historic events with this after it gets in a release and is vendored.

Comment 1

[Chris H-C :chutten]

Actually, upon further examination, on first run we should just treat it like subsequent runs: If we're overdue, send "overdue". If not, schedule a "today" ping. Let's just ensure that's covered by tests, shall we?

Comment 2

[BMO Automation]

Attachment: bug 1800646 - MPS should set initial last-sent-build

Comment 3

[Chris H-C :chutten]

chutten merged PR #2274: "bug 1800646 - MPS should set initial last-sent-build" in 60a59fd.