1800700 - Update Default search suggestion header to be compliant with partner requirements

Status: VERIFIED FIXED

(Firefox for Android :: Search, task)

Description

[[:skhan]]

Google has notified us that the way in which we are displaying search result suggestions in our address bars is not compliant with their design requirements.

At present, there is no explicit line-item level disclosure of the source of Google, or other default search provider search suggestions in the address bar.

Acceptance Criteria

Default partner search suggestions shown in the Firefox Android address bars are sufficiently labeled to be in compliance with Google’s requirements.

Comment 1

[BMO Automation]

Attachment: Bug 1800700 - Add default search suggest header

Comment 2

[[:skhan]]

Design : https://www.figma.com/file/epu0Sj6mCPk7K282sNpHgI/Site?node-id=874%3A14793

Comment 3

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1800700 - Add default search suggest header (backport #157) (#204)

Comment 4

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1800700 - Add default search suggest header (#205)

Comment 5

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Revert "Bug 1800700 - Add default search suggest header" (#206)

Comment 6

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1800700 - Add default search suggest header (#234)

Comment 7

[Chris Peterson [:cpeterson]]

Sarah fixed this bug in 110:

https://github.com/mozilla-mobile/firefox-android/commit/1534ab56e87cad8ad1bf0bb59ea5beec958b57f1

Comment 8

[Delia Pop (Android QA)]

Hi, we began testing this on the latest Nightly 111.0a1 from 01/23 and Beta 109.0b3 with Xiaomi 12 Pro (Android 13). The default search suggestion header is displayed accordingly, as follows:

• "Google Search" for Google;
• "[Engine Name] search" for Bing, Amazon.com, DuckDuckGo, eBay and Wikipedia.
  On Nightly, with Unified Search enabled, the header is also properly displayed for Google, Bing and DuckDuckGo, while the other search engines cannot be selected. We will conduct more testing on Wednesday, since tomorrow is a national holiday, and I will leave the "qe-verify+" flag for visibility.

Comment 9

[Delia Pop (Android QA)]

Attachment: Compliant_search_suggestions.png

Comment 10

[Delia Pop (Android QA)]

We finished testing default search suggestion header on the additional search engines YouTube, Reddit and custom search engine added, with no issues encountered.
The header is also displayed accordingly when Unified Search is enabled for the general search engines Google, Bing and DuckDuckGo and custom search engine added.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4db896fc322
Add default search suggest header
https://hg.mozilla.org/integration/autoland/rev/44054718003d
Add default search suggest header
https://hg.mozilla.org/integration/autoland/rev/6f35dcdca18b
[fenix] Bug 1800700 - Add default search suggest header