1800856 - [wpt-sync] Sync PR 36987 - Fixed WPT: "getDisplayMedia() must adhere to frameRate if set"

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 36987 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36987
Details from upstream follow.

Tove Petersson <[e-mail]> wrote:

Fixed WPT: "getDisplayMedia() must adhere to frameRate if set"

Replaced the ||-operator with a ??-operator in the frames() helper-function to treat getVideoPlaybackQuality()?.totalVideoFrames == 0 as a valid return-value.

Bug: 1384645
Change-Id: I072413ccb3980dcc89e96ebc0298d1085dde1d20
Reviewed-on: https://chromium-review.googlesource.com/4027916
WPT-Export-Revision: c6609b780e0b3a344812827dd1758cac3f998219

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=58e8fdbe84203de953209100f3e7ae02fbc5b984

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 60 subtests

Status Summary

Firefox

OK : 1
PASS : 49
CRASH: 1
FAIL : 11

Chrome

OK : 1
PASS : 59
FAIL : 1

Safari

OK : 1
PASS : 42
FAIL : 18

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Crashes

• /screen-capture/getdisplaymedia.https.html [wpt.fyi]: CRASH [Gecko-windows10-32-2004-qr-debug, Gecko-windows10-64-2004-qr-debug], OK [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] linked bugs:Bug 1788563, Bug 1798556

Firefox-only Failures

• /screen-capture/getdisplaymedia.https.html [wpt.fyi]
  • displaySurface is supported: FAIL

New Tests That Don't Pass

• /screen-capture/getdisplaymedia.https.html [wpt.fyi]: CRASH [Gecko-windows10-32-2004-qr-debug, Gecko-windows10-64-2004-qr-debug], OK [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: OK, Safari: OK)
  • getDisplayMedia() must adhere to frameRate if set: FAIL (Chrome: PASS, Safari: FAIL)
  • getDisplayMedia({"video":{"displaySurface":"monitor"}}) with getSettings: FAIL (Chrome: PASS, Safari: FAIL)
  • getDisplayMedia({"video":{"displaySurface":"window"}}) with getSettings: FAIL (Chrome: PASS, Safari: FAIL)
  • getDisplayMedia({"video":{"displaySurface":"browser"}}) with getSettings: FAIL (Chrome: PASS, Safari: FAIL)
  • displaySurface is supported: FAIL (Chrome: PASS, Safari: PASS)
  • getDisplayMedia({"selfBrowserSurface":"invalid"}) must fail with TypeError: FAIL (Chrome: PASS, Safari: FAIL)
  • getDisplayMedia({"surfaceSwitching":"invalid"}) must fail with TypeError: FAIL (Chrome: PASS, Safari: FAIL)
  • getDisplayMedia({"systemAudio":"invalid"}) must fail with TypeError: FAIL (Chrome: PASS, Safari: FAIL)
  • suppressLocalAudioPlayback is supported: FAIL (Chrome: PASS, Safari: FAIL)
  • getDisplayMedia({"audio":{"suppressLocalAudioPlayback":true}}) with getSettings: FAIL (Chrome: PASS, Safari: FAIL)
  • getDisplayMedia({"audio":{"suppressLocalAudioPlayback":false}}) with getSettings: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

• /screen-capture/getdisplaymedia.https.html [wpt.fyi]: CRASH [Gecko-windows10-32-2004-qr-debug, Gecko-windows10-64-2004-qr-debug], OK [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: OK, Safari: OK) linked bugs:Bug 1788563, Bug 1798556

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/daf6e97a92c0
[wpt PR 36987] - Fixed WPT: "getDisplayMedia() must adhere to frameRate if set", a=testonly
https://hg.mozilla.org/integration/autoland/rev/a93baaa5be5e
[wpt PR 36987] - Update wpt metadata, a=testonly

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/daf6e97a92c0
https://hg.mozilla.org/mozilla-central/rev/a93baaa5be5e