1800972 - Allow to drag multiple files to file manager

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

This is followup from Bug 377621. Allow to drag multiple files from attachment to file manager.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: all.patch

Raw all-in-one patch.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1800972 [Linux] Update logging and clean up of nsDragService r?emilio

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1800972 [Linux] Use XdndDirectSave on X.org only as it's no supported on XWayland r?emilio

Depends on D162463

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1800972 [Linux] Factor out XDND to extra function r?emilio

Depends on D162465

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1800972 [Linux] Factor out image drop r?emilio

Depends on D162466

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1800972 [Linux] Factor out text mime types to extra function r?emilio

Depends on D162467

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1800972 [Linux] Don't query fallback mime type for image/XDND mime types r?emilio

Depends on D162468

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1800972 [Linux] Implement drag of multiple items r?emilio

• Remove nsDragService::CreateURIList() and replace it by nsDragService::SourceDataGetUriList().
  It reads all items from nsITransferable and put them to uri list.
  If data drop is performed to another application which doesn't have access to internal data storages (mailbox:// for instance),
  request download and save referenced items to /tmp directory.

• Implement SourceDataAppendURLItem() which read one item from nsITransferable and append it to uri list.
  Download and store internal files in /tmp directory.

• Make CreateTempFile() to block native events processing. nsIOutputStream/nsIInputStream read and write operations run
  event loop and can abort D&D operation before we write all data to /tmp. Use nsAppShell to block native event processing
  during read/write to prevent it.

Depends on D162469

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1800972 [Linux] Convert char* to GUniquePtr at nsDragService::SourceDataGetXDND() r?emilio

Depends on D162473

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5db4ba59d636
[Linux] Update logging and clean up of nsDragService r=emilio
https://hg.mozilla.org/integration/autoland/rev/9ba70bea65b3
[Linux] Use XdndDirectSave on X.org only as it's no supported on XWayland r=emilio
https://hg.mozilla.org/integration/autoland/rev/e2332b082030
[Linux] Factor out XDND to extra function r=emilio
https://hg.mozilla.org/integration/autoland/rev/bfddce18f8bb
[Linux] Factor out image drop r=emilio
https://hg.mozilla.org/integration/autoland/rev/a90dc6dca287
[Linux] Factor out text mime types to extra function r=emilio
https://hg.mozilla.org/integration/autoland/rev/67791213debd
[Linux] Don't query fallback mime type for image/XDND mime types r=emilio
https://hg.mozilla.org/integration/autoland/rev/fdeb8291c355
[Linux] Implement drag of multiple items r=emilio
https://hg.mozilla.org/integration/autoland/rev/575345f98b95
[Linux] Convert char* to GUniquePtr at nsDragService::SourceDataGetXDND() r=emilio

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5db4ba59d636
https://hg.mozilla.org/mozilla-central/rev/9ba70bea65b3
https://hg.mozilla.org/mozilla-central/rev/e2332b082030
https://hg.mozilla.org/mozilla-central/rev/bfddce18f8bb
https://hg.mozilla.org/mozilla-central/rev/a90dc6dca287
https://hg.mozilla.org/mozilla-central/rev/67791213debd
https://hg.mozilla.org/mozilla-central/rev/fdeb8291c355
https://hg.mozilla.org/mozilla-central/rev/575345f98b95

Comment 12

[Martin Stránský [:stransky] (ni? me)]

D&D of multiple targets may fail on Wayland due to different message processing. Let's handle that at Bug 1802098.