1800993 - Add new telemetry for dynamic wikipedia results

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Dale Harvey (:daleharvey)]

As specified @ https://mozilla-hub.atlassian.net/browse/SNT-362

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: Bug 1800993 - Add telemetry for dynamic wikipedia results. r=adw

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba7612a763a0
Add telemetry for dynamic wikipedia results. r=adw

Comment 3

[Dale Harvey (:daleharvey)]

Attachment: data-review-request.txt

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for needing data-review

Backout link: https://hg.mozilla.org/integration/autoland/rev/c1afbeee30159ab0acb47ee391ae7e18e0f6ef0c

Comment 5

[Elise Richards]

Hi :daleharvey! I'm taking a look at your data review request and it seems like the majority of those probes already exist? Why are they included in this?

Comment 6

[Dale Harvey (:daleharvey)]

Attachment: data-review-request.txt

Ah apologies 2 of the scalars for block already existed, I was normalising the other types (click, impression, help) scalars to match the layout of the block ones and added the block ones in here accidentally, should be fixed now

Comment 7

[Chris H-C :chutten]

Comment on attachment 9307427 [details]
data-review-request.txt

Redirecting to Elise

Comment 8

[Elise Richards]

Comment on attachment 9307427 [details]
data-review-request.txt

Data Review Form

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

   • Yes, through Scalars.yaml, Events.yaml, and firefox-suggest-telemetry.rst files

2. Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.

   • Yes, through the standard telemetry opt-out.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

   • Yes, this a permanent collection and it will be monitored by [e-mail]

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

   • Category 2 - interaction data

5. Is the data collection request for default-on or default-off?

   • Default-on

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

   • No

7. Is the data collection covered by the existing Firefox privacy notice?

   • Yes

8. Does the data collection use a third-party collection tool? If yes, escalate to legal.

   • No

Result

data-review+

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4e6cfe2535f
Add telemetry for dynamic wikipedia results. r=adw

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f4e6cfe2535f

Comment 11

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on Firefox Release 111.0.1 (Build ID: 20230321111920) on Firefox Beta 112.0b9 (Build ID: 20230330182947) and the latest Nightly 113.0a1 (Build ID: 20230402214746) on Windows 10 x64, macOS 12.4 and Linux Mint 20.4.

• The dynamic wikipedia events are correctly registered.
• The dynamic wikipedia keyed scalars are correctly registered.
• The Contextual services impression and click pings are correctly registered.