Closed Bug 1801020 Opened 2 years ago Closed 2 years ago

CacheFileIOManager.cpp fails to build with --disable-backgroundtasks

Categories

(Core :: Networking: Cache, defect, P2)

Product:
Core
Component:
Networking: Cache
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
109 Branch
Tracking Flags:
Tracking Status
firefox-esr102 --- unaffected
firefox107 --- unaffected
firefox108 --- fixed
firefox109 --- fixed

People

(Reporter: mathew.hodson, Assigned: mathew.hodson)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [necko-triaged])

Attachments

(2 files)

Bug 1801020 - Fix build failure with --disable-backgroundtasks. r?valentin
48 bytes, text/x-phabricator-request
Details | Review
Bug 1801020 - Fix build failure with --disable-backgroundtasks.
48 bytes, text/x-phabricator-request
diannaS
: approval-mozilla-beta+
Details | Review

The new includes from bug 1791675 need #ifdef guards.

Regressed by: 1791675
Assignee: nobody → mathew.hodson
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

Set release status flags based on info from the regressing bug 1791675

status-firefox107: --- → unaffected
status-firefox108: --- → affected
status-firefox109: --- → affected
status-firefox-esr102: --- → unaffected
Severity: -- → S4
Priority: -- → P2
Whiteboard: [necko-triaged]
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/autoland/rev/3b5a8f67189b Fix build failure with --disable-backgroundtasks. r=valentin,necko-reviewers,nalexander,saschanaz

https://hg.mozilla.org/mozilla-central/rev/3b5a8f67189b

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox109: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch

The patch landed in nightly and beta is affected.
:mathew.hodson, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox108 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(mathew.hodson)
  • User impact if declined Some downstream distributions might be unable to build.
  • Code covered by automated testing yes
  • Fix verified in Nightly yes
  • Needs manual QE test no
  • Steps to reproduce for manual QE testing none
  • Risk associated with taking this patch low
  • Explanation of risk level Affects only nondefault configurations.
  • String changes made/needed none
  • Is Android affected? yes
Flags: needinfo?(mathew.hodson)

Comment on attachment 9304538 [details]
Bug 1801020 - Fix build failure with --disable-backgroundtasks.

Approved for 108.0b6

Attachment #9304538 - Flags: approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: