1801085 - Codepen demo (https://codepen.io/shubniggurath/pen/qeXRrW) is still slower with gpu-canvas compared to non-gpu-canvas (part3)

Status: RESOLVED WORKSFORME

(Core :: Graphics: Canvas2D, defect)

Description

[Mayank Bansal]

Enable gpu-canvas
Go to : https://codepen.io/shubniggurath/pen/qeXRrW

gpu-canvas: https://share.firefox.dev/3EdrHP3
non-gpu-canvas: https://share.firefox.dev/3GnYXFS

Subjectively, the non-gpu-canvas animations feel smoother

I have already filed two bugs now for the same demo (bug 1800581 and bug 1759792) so i dont know if it is worthwhile to spend more time on this demo. I leave this decision to Mozilla.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Lee, it looks like we're still getting stuck waiting for source surfaces.

Comment 2

[Lee Salzman [:lsalzman]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #1)

Lee, it looks like we're still getting stuck waiting for source surfaces.

That's because the user left Direct2D remote canvas enabled along with GPU-accelerated canvas, which is not going to play nicely together. Please make sure you have disabled Direct2D canvas before trying to enabled accelerated canvas on Windows.

Comment 3

[Mayank Bansal]

Attachment: about:support

Comment 4

[Mayank Bansal]

(In reply to Lee Salzman [:lsalzman] from comment #2)

(In reply to Jeff Muizelaar [:jrmuizel] from comment #1)

Lee, it looks like we're still getting stuck waiting for source surfaces.

That's because the user left Direct2D remote canvas enabled along with GPU-accelerated canvas, which is not going to play nicely together. Please make sure you have disabled Direct2D canvas before trying to enabled accelerated canvas on Windows.

I dont know what i am doing wrong. All i know is to enable gpu-canvas, I set gfx.canvas.accelerated=true.
I have attached my about:support for reference.

Comment 5

[Lee Salzman [:lsalzman]]

(In reply to Mayank Bansal from comment #4)

(In reply to Lee Salzman [:lsalzman] from comment #2)

(In reply to Jeff Muizelaar [:jrmuizel] from comment #1)

Lee, it looks like we're still getting stuck waiting for source surfaces.

That's because the user left Direct2D remote canvas enabled along with GPU-accelerated canvas, which is not going to play nicely together. Please make sure you have disabled Direct2D canvas before trying to enabled accelerated canvas on Windows.

I dont know what i am doing wrong. All i know is to enable gpu-canvas, I set gfx.canvas.accelerated=true.
I have attached my about:support for reference.

You will need to set "gfx.direct2d.disabled" to true, and then restart. Otherwise the two methods of remoting will try to fight each other, and the result won't be pretty.

Edit: meant to say "gfx.direct2d.disabled".

Comment 6

[Mayank Bansal]

New profile: https://share.firefox.dev/3EFEZ8u
This is much better.

Shouls this pref be automatically set when gpu-canvas is enabled?
Additionally, does this pref impact general WR ?

Comment 7

[Lee Salzman [:lsalzman]]

(In reply to Mayank Bansal from comment #6)

New profile: https://share.firefox.dev/3EFEZ8u
This is much better.

Shouls this pref be automatically set when gpu-canvas is enabled?
Additionally, does this pref impact general WR ?

Right now accelerated canvas is not meant to be used on Windows except for testing purposes, with the standard "caveat emptor", that it's not an officially supported configuration as of yet. To the extent it will interop with D2D and in which direction has not been decided yet.

Comment 8

[Mayank Bansal]

Cool.
Though I still think that for Windows Nightly users who manually enable gpu-canvas, the other pref should also be set automatically. Otherwise, we unknowingly would not be testing the "full" gpu-canvas, and filing wrong/misleading bugs.

Closing this bug as WORKSFORME.

Comment 9

[Lee Salzman [:lsalzman]]

(In reply to Mayank Bansal from comment #8)

Cool.
Though I still think that for Windows Nightly users who manually enable gpu-canvas, the other pref should also be set automatically. Otherwise, we unknowingly would not be testing the "full" gpu-canvas, and filing wrong/misleading bugs.

Closing this bug as WORKSFORME.

If you want you could leave this bug open for that issue, though I can't promise there will be a quick resolution to it.