1801138 - Drop-down menus items with empty values have a smaller height compared to the ones that have values

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: min_height.gif

Found in

• 109.0a1 (2022-11-17)

Affected versions

• 109.0a1 (2022-11-17)

Tested platforms

• Affected platforms: Windows 10x64, Ubuntu 20.04,
• Unaffected platforms: macOS 11

Steps to reproduce

1. Open Bugzilla and log in.
2. Open a random issue and click on Edit Bug.
3. Click on a random flag from Bug flags and hover over the options.

Expected result

• All options have the same height.

Actual result

• Empty value option has reduced height.

Regression range

• Last good revision: 0f84b85f120f45fe6bad63d5e26b5ba4cd89f801
  First bad revision: fd69d6b3aeb8e1e04334a0885f60966883a69c08
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0f84b85f120f45fe6bad63d5e26b5ba4cd89f801&tochange=fd69d6b3aeb8e1e04334a0885f60966883a69c08
  Possible regressor: bug 1799460.

Additional notes

• Attached a screen recording.

Comment 1

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: minimum test case.html

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1801138 - Ensure empty label values don't collapse. r=Gijs

Add a zwsp character to ensure they're not considered an empty line.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61a6e8126253
Ensure empty label values don't collapse. r=dao

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing mochitest failures on test_label.xhtml

Backout link

Push with failures

Failure log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c80c39dce22c
Ensure empty label values don't collapse. r=dao

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c80c39dce22c

Comment 7

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed using Firefox 109.0a1 (2022-12-12) on Windows 10x64 and Ubuntu 20.04. The dropdown menus have the same height.