1801157 - Context menu `Search Google for "hogehoge"` would not update for selected text or on a link

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Alice0775 White]

Steps to reproduce:

1. Select some text foo
2. Right click
   --- Context menu indicates Search Google for "foo"
3. Select the other text bar
4. Right click
   --- Context menu still indicate Search Google for "foo" ---BUG

OR

1. Right click on a link foo
   --- Context menu indicates Search Google for "foo"
2. Right click on the other link bar
   --- Context menu still indicate Search Google for "foo" ---BUG

Actual Results:
Context menu Search Google for "xxxx" would not update

Expected Results:
Context menu Search Google for "xxxx" should update

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=efbd04cb07486419679cf588ba6095f7ef9edef6&tochange=fd69d6b3aeb8e1e04334a0885f60966883a69c08

Suspect: Bug 1799460

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1799460, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1801157 - Fix dynamic value change of label/description with accesskey. r=smaug

While at it move GetAttributeChangeHint to relevant implementations.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d172102d49f0
Fix dynamic value change of label/description with accesskey. r=smaug

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f13228fb451
Fix last minute typo in the test.

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d172102d49f0
https://hg.mozilla.org/mozilla-central/rev/6f13228fb451

Comment 7

[erosman]

Does the fix also fixes the copy/paste issue listed in bug 1801203?

Comment 8

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproduced on Nightly 109.0a1(build ID: 20221117093901) on Windows 10. Verified as fixed on Firefox 109.0(build ID: 20230109161414) Nightly 110.0a1(build ID: 20230110214526) on macOS 12, Windows 10, Ubuntu 22.