1801198 - fontBoundingBoxAscent is not enabled

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Matias]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.0.0 Safari/537.36
Firefox for Android

Steps to reproduce:

var _ctx = document.createElement("canvas").getContext("2d");
var m = _ctx.measureText("");
return m.fontBoundingBoxAscent

Actual results:

No results found for fontBoundingBoxAscent

Expected results:

a ascent number of the font need to return

Comment 1

[Andrew McCreight [:mccr8]]

It looks like this property is currently disabled by the pref dom.textMetrics.fontBoundingBox.enabled. Anyways, this is not a security bug so I'm going to unhide it.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug is invalid.
If you think the bot is wrong, please reopen the bug and move it back to its prior component.
If your bug description is written in a non-English language, please use Google Translate or a similar service to translate it.

Please note that this is a production bug database used by the Mozilla community to develop Firefox, Thunderbird and other products.
Filing test bugs here will waste the time of our contributors, volunteers and employees.
Accounts that abuse bugzilla.mozilla.org will be disabled.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Jonathan, what's the status of shipping the extended attributes?

Comment 4

[Jonathan Kew [:jfkthame]]

We could, we've got an implementation. But last I checked, the values returned by webkit/blink/gecko aren't necessarily interoperable, e.g. see https://github.com/web-platform-tests/interop/issues/159#issuecomment-1303361603.

For these to really be useful to authors, I think they need to be more carefully specified so that we can all give consistent values. (Which may get tricky because of the legacy of fonts containing multiple, conflicting versions of metrics; and different platforms/applications having various heuristics to decide which to use...)

Comment 5

[Jonathan Kew [:jfkthame]]

According to https://wpt.fyi/results/html/canvas?label=master&label=stable&aligned&q=fontboundingbox, it looks like the other browsers are shipping this, and we're the odd one out. I'm inclined to think we could pref it on.

(Looking more broadly at https://wpt.fyi/results/html/canvas?label=master&label=stable&aligned&q=2d.text.measure, there's less interop for other extended TextMetrics attributes like baselines and emheights, so I'm proposing only to flip the pref for fontBoundingBox at this stage.)

Testing locally, with the pref enabled we pass the test using Ahem, but on the one using the CanvasTest font, we have a 1px discrepancy from Chrome's result. This is because we're rounding the font metrics to pixels differently. The font and styles used by the test would in theory result in fractional-pixel metrics, but Chrome rounds the ascent and descent to the nearest pixel, while we round them up. AFAIK, the spec doesn't explicitly address this (I don't see any reason we couldn't return precise fractional-pixel values, even), and in practice metrics that come from various font backends are likely to show minor discrepancies between platforms. So I think the way forward here is to make the test use an "approx_equals" assertion, to allow for variations in how the font system computes/rounds metrics.

Taking that into account, we seem to have interoperability at a basic level on this feature, and it would be useful for authors to have it available.

Comment 6

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1801198 - patch 1 - Allow 1px of variation in canvas TextMetrics.fontBoundingBox* test, rather than assuming a specific rounding behavior. r=#gfx-reviewers

Comment 7

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1801198 - patch 2 - Enable the fontBoundingBox{Ascent,Descent} attributes in canvas TextMetrics. r=#gfx-reviewers

Depends on D181293

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f41dfa25b93
patch 1 - Allow 1px of variation in canvas TextMetrics.fontBoundingBox* test, rather than assuming a specific rounding behavior. r=gfx-reviewers,lsalzman
https://hg.mozilla.org/integration/autoland/rev/bca7a8665982
patch 2 - Enable the fontBoundingBox{Ascent,Descent} attributes in canvas TextMetrics. r=gfx-reviewers,lsalzman

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40619 for changes under testing/web-platform/tests

Comment 10

[Cristina Horotan [:chorotan]]

Backed out for causing wpt failures at idlharness.https.html

Backout: https://hg.mozilla.org/integration/autoland/rev/3ca0465e2f35660923f4d572c2ceb4254fc931a4

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=bca7a8665982b1110fa8b678873a845aea96999f

Failure log: https://treeherder.mozilla.org/logviewer?job_id=419852617&repo=autoland&lineNumber=13532

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fbaae95aa864
patch 1 - Allow 1px of variation in canvas TextMetrics.fontBoundingBox* test, rather than assuming a specific rounding behavior. r=gfx-reviewers,lsalzman
https://hg.mozilla.org/integration/autoland/rev/b2d23872d92d
patch 2 - Enable the fontBoundingBox{Ascent,Descent} attributes in canvas TextMetrics. r=gfx-reviewers,lsalzman

Comment 13

[Cristian Tuns]

Backed out for causing wpt failures in idlharness.worker.html

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-PASS | /html/dom/idlharness.worker.html | TextMetrics interface: attribute fontBoundingBoxAscent - expected FAIL

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 15

[Mathew Hodson]

Maybe make this depend on bug 1102584 and block bug 1119470 so it's easier to find.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16840df74cb4
patch 1 - Allow 1px of variation in canvas TextMetrics.fontBoundingBox* test, rather than assuming a specific rounding behavior. r=gfx-reviewers,lsalzman
https://hg.mozilla.org/integration/autoland/rev/d238e609ab5c
patch 2 - Enable the fontBoundingBox{Ascent,Descent} attributes in canvas TextMetrics. r=gfx-reviewers,lsalzman

Comment 17

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/16840df74cb4
https://hg.mozilla.org/mozilla-central/rev/d238e609ab5c

Comment 18

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 19

[Hamish Willee]

FF116 MDN docs can be tracked in https://github.com/mdn/content/issues/27758#issuecomment-1635199574